You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2015/12/28 19:03:14 UTC
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/192
checkstyle and semver maven plugin upgrade
@chandnisingh please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core devel-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #192
----
commit c64e26ef4a6d3f7743f71d32d25880b42073229d
Author: MalharJenkins <je...@datatorrent.com>
Date: 2015-12-28T18:00:13Z
checkstyle and semver maven plugin upgrade
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by gauravgopi123 <gi...@git.apache.org>.
Github user gauravgopi123 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/192#issuecomment-168074929
Can this be captured in a JIRA so that it is clear? Neither was any of this mentioned in the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/192#issuecomment-168074286
we need japicmp update because it has some features exclusion/inclusion based on annotation. Apex may need that feature for new APIs and Malhar needs it now because in its next version it will inherit this plugin from Apex instead of re-declaration.
Checkstyle is needed as well because seems like there is a bug fix and which is why the number of violation is decremented.
@vrozov could you please rebase so that I can merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/192
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by gauravgopi123 <gi...@git.apache.org>.
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/192#discussion_r48623687
--- Diff: pom.xml ---
@@ -336,7 +336,7 @@
<plugin>
<groupId>com.github.siom79.japicmp</groupId>
<artifactId>japicmp-maven-plugin</artifactId>
- <version>0.6.1</version>
+ <version>0.6.2</version>
<configuration>
--- End diff --
Why are these updates needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/192#issuecomment-168121154
The new semver version supports annotations, so we can exclude not stable APIs from the check. The new checkstyle version has few bug fixes that have impact on the Apex current code (please note change in the # of allowed violations).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/192#issuecomment-168121992
Can you fix the build failure and I will pull it in:
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on project apex-engine: You have 4402 Checkstyle violations. The maximum number of allowed violations is 4401. -> [Help 1]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: checkstyle and semver maven plug...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/192#issuecomment-168102644
Why the change? Does it fix an issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---