You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/22 18:41:34 UTC
[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #174: [YUNIKORN-226] Remove panic calls from scheduler
yangwwei commented on a change in pull request #174:
URL: https://github.com/apache/incubator-yunikorn-core/pull/174#discussion_r443754902
##########
File path: pkg/cache/cluster_info.go
##########
@@ -85,7 +85,7 @@ func (m *ClusterInfo) handleSchedulerEvents() {
case *commonevents.RemoveRMPartitionsEvent:
m.processRemoveRMPartitionsEvent(v)
default:
- panic(fmt.Sprintf("%s is not an acceptable type for scheduler event.", reflect.TypeOf(v).String()))
+ log.Logger().Warn(fmt.Sprintf("%s is not an acceptable type for scheduler event.", reflect.TypeOf(v).String()))
Review comment:
hi @HuangTing-Yao
This should be at the ERROR level.
Another thing is, instead of using `fmt`, can you pls follow the logging format such as https://github.com/apache/incubator-yunikorn-core/blob/772e3cbdbdbda397468f19e09f137433caf5f144/pkg/scheduler/scheduler.go#L149-L153.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org