You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/03/11 11:56:53 UTC

[GitHub] [hive] deniskuzZ commented on a change in pull request #2061: HIVE-24871: Initiator / Cleaner performance metrics

deniskuzZ commented on a change in pull request #2061:
URL: https://github.com/apache/hive/pull/2061#discussion_r592299917



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -171,9 +176,12 @@ public void run() {
               StringUtils.stringifyException(t));
         }
         finally {
-          if(handle != null) {
+          if (handle != null) {
             handle.releaseLocks();
           }
+          if (metricsEnabled) {

Review comment:
       checked: it won't fail and won't report metric in this case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org