You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/09 01:16:32 UTC
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5112: Support remove schema dynamically#step 3
kimmking commented on a change in pull request #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112#discussion_r405902562
##########
File path: shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/ShardingSchemaService.java
##########
@@ -71,4 +71,11 @@
* @param dataSourceConfiguration data source configuration
*/
void addSchemaConfiguration(String schemaName, String ruleConfiguration, String dataSourceConfiguration);
+
+ /**
+ * Delete schema configuration.
+ *
+ * @param schemaName schema name
+ */
+ void deleteSchemaConfiguration(String schemaName);
Review comment:
deleteSchema is ok,
AddSchemaConfiguration means add schema from configuration parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services