You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by pdxrunner <gi...@git.apache.org> on 2016/08/18 22:25:34 UTC
[GitHub] incubator-geode pull request #234: GEODE-1128: Fixes for colocation configur...
GitHub user pdxrunner opened a pull request:
https://github.com/apache/incubator-geode/pull/234
GEODE-1128: Fixes for colocation configuration problems
1) Test parent regions on child region creates and throw IllegalStateException
if parent region does not exist.
Missing parent regions were not being checked for, which resulted in NPE's getting thrown.
2) Log warnings when persistent colocated child regions don't exist.
Persistent data recovery cannot complete for any region in a colocation hierarchy if there are child regions that don't exist. The absence of any warning logs for this condition made it difficult to diagnose configuration problems.
3) Create Unit and DUnit tests for new exceptions and warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdxrunner/incubator-geode feature/GEODE-1128
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/234.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #234
----
commit fd6b6b1c52f81977c990259853c2dd996f3a280d
Author: Ken Howe <kh...@pivotal.io>
Date: 2016-08-18T22:00:22Z
GEODE-1128: Fixes for colocation configuration problems
Test parent regions on child region creates and throw IllegalStateException
if parent region does not exist
Log warnings when persistent colocated child regions don't exist
Create Unit and DUnit tests for new exceptions and warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #234: GEODE-1128: Fixes for colocation configur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/234
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #234: GEODE-1128: Fixes for colocation configuration p...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/incubator-geode/pull/234
this looks good, I will pull it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---