You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/22 22:45:41 UTC
[GitHub] [geode] bschuchardt opened a new pull request #6168: GEODE-8997: remove protobuf client server code
bschuchardt opened a new pull request #6168:
URL: https://github.com/apache/geode/pull/6168
This removes the experimental Protobuf-based client/server subproject
and associated files. Protobuf is no longer included as a Geode dependency.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6168:
URL: https://github.com/apache/geode/pull/6168#issuecomment-804462247
This pull request **fixes 1 alert** when merging 2e6f585e4afb83d979d71587ead10ba9a310258a into 55a6e065960694bbe7856cbea186c55aac6c7867 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e893c157b4c9df02710581fa0ca17fb327140f7a)
**fixed alerts:**
* 1 for Dereferenced variable may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] bschuchardt edited a comment on pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
bschuchardt edited a comment on pull request #6168:
URL: https://github.com/apache/geode/pull/6168#issuecomment-804974523
> I'm not sure when it was decided that Geode was not to support Protobuf any more. Please point me at the dev list thread.
good question Udo. There hasn't been open discussion about removing this and there should be.
I started one this morning and will let it go for a few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6168:
URL: https://github.com/apache/geode/pull/6168#issuecomment-805117965
This pull request **fixes 1 alert** when merging 096ae2a3d73387d1edd4ff9899f602c1ca461d00 into 0abd7667b324da3a88fa341675b68f08118c83cb - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-fd6f9ec8dfd8182a0d55de437ada1ef4c1699438)
**fixed alerts:**
* 1 for Dereferenced variable may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6168:
URL: https://github.com/apache/geode/pull/6168#issuecomment-805247915
This pull request **fixes 1 alert** when merging d14f6d9538862d6d09c49b1dc1bfc7ccf0a83330 into 863243af44e9f4ea2e501c3b24a62a1647a7df16 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-30fa4c9e538cd7fe5ffa06dbae06095e0e347678)
**fixed alerts:**
* 1 for Dereferenced variable may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] bschuchardt commented on pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
bschuchardt commented on pull request #6168:
URL: https://github.com/apache/geode/pull/6168#issuecomment-804974523
> I'm not sure when it was decided that Geode was not to support Protobuf any more. Please point me at the dev list thread.
good question Udo. There hasn't been open discussion about removing this and there should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] bschuchardt merged pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
bschuchardt merged pull request #6168:
URL: https://github.com/apache/geode/pull/6168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6168: GEODE-8997: remove protobuf client server code
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6168:
URL: https://github.com/apache/geode/pull/6168#issuecomment-812181938
This pull request **fixes 1 alert** when merging 7dc797afd25907428e15f1053bf8c6e5fb94a6f3 into b7299661375ed0926303f63484cb46dae1e12ffa - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-94d82103186b85e2f6302b56bb7d2f9056bc6f32)
**fixed alerts:**
* 1 for Dereferenced variable may be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org