You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by koertkuipers <gi...@git.apache.org> on 2018/09/01 19:42:27 UTC
[GitHub] spark pull request #22312: [SPARK-17916][SQL] Fix new behavior when quote is...
GitHub user koertkuipers opened a pull request:
https://github.com/apache/spark/pull/22312
[SPARK-17916][SQL] Fix new behavior when quote is set and fix old behavior when quote is unset
## What changes were proposed in this pull request?
1) Set nullValue to quoted empty string respecting quote value
2) Fall back to old behavior of unquoted null if quote is not set
## How was this patch tested?
Two new tests that will fail without these fixes
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tresata-opensource/spark feat-csv-null-unquoted
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22312.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22312
----
commit ad3a11d5c6ead4133195e81f59852db669de5b56
Author: Koert Kuipers <ko...@...>
Date: 2018-09-01T18:59:35Z
fix new behavior when quote is changed and fix old behavior when quote is unset
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22312
**[Test build #95581 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95581/testReport)** for PR 22312 at commit [`ad3a11d`](https://github.com/apache/spark/commit/ad3a11d5c6ead4133195e81f59852db669de5b56).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2761/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22312: [SPARK-17916][SQL] Fix new behavior when quote is...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22312
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95582/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22312
#22234 was already open. Wouldn't it be able to workaround if it's configurable?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2760/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22312
**[Test build #95581 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95581/testReport)** for PR 22312 at commit [`ad3a11d`](https://github.com/apache/spark/commit/ad3a11d5c6ead4133195e81f59852db669de5b56).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22312
**[Test build #95582 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95582/testReport)** for PR 22312 at commit [`5772404`](https://github.com/apache/spark/commit/57724049dbe40d4b8b38a249084feff4363b99b8).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22312
**[Test build #95582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95582/testReport)** for PR 22312 at commit [`5772404`](https://github.com/apache/spark/commit/57724049dbe40d4b8b38a249084feff4363b99b8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22312: [SPARK-17916][SQL] Fix new behavior when quote is set an...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22312
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95581/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org