[GitHub] ivankelly commented on a change in pull request #1823: [scripts] improve bookkeeper script to better handle standalone command

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #1823: [scripts] improve bookkeeper script to better handle standalone command
URL: https://github.com/apache/bookkeeper/pull/1823#discussion_r235371648
 
 

 ##########
 File path: bin/common.sh
 ##########
 @@ -146,7 +175,7 @@ find_module_jar() {
     BUILT_JAR=$(find_module_jar_at ${BK_HOME}/${MODULE_PATH}/target ${MODULE_NAME})
     if [ -z "${BUILT_JAR}" ]; then
       echo "Couldn't find module '${MODULE_NAME}' jar." >&2
-      read -p "Do you want me to run \`mvn package -DskiptTests\` for you ? " answer
+      read -p "Do you want me to run \`mvn package -DskiptTests\` for you ? (y|n) " answer
       case "${answer:0:1}" in
         y|Y )
           mvn package -DskipTests -Dstream
 
 Review comment:
   pipe out to a log file in $TMP and then 
   echo "Building, see output at $LOGFILE" >&2
   
   Otherwise this kicks off and it looks like the script has hung.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services