You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/14 07:52:12 UTC

[jira] [Commented] (THRIFT-227) Byte[] in collections aren't pretty printed like regular binary fields

    [ https://issues.apache.org/jira/browse/THRIFT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493614#comment-14493614 ] 

ASF GitHub Bot commented on THRIFT-227:
---------------------------------------

GitHub user roshan opened a pull request:

    https://github.com/apache/thrift/pull/441

    THRIFT-227 Pretty print binary collections in Java

    `set<binary>` and `list<binary>` don't have pretty printers corresponding to `binary`. This adds them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/roshan/thrift THRIFT-227_pretty_print_byte_collections

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #441
    
----
commit 5da68694fec6a51e97f5a75823babb1074e32eb2
Author: Roshan George <ro...@arjie.com>
Date:   2015-04-13T03:40:26Z

    THRIFT-227 Pretty print binary collections

----


> Byte[] in collections aren't pretty printed like regular binary fields
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-227
>                 URL: https://issues.apache.org/jira/browse/THRIFT-227
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Trivial
>
> In toString, we just delegate to the toString method of our embedded collection objects, which in turn call the toString of the byte[] collection elements. This results in [B@12fa2134 instead of 01 a3 17. It'd be nice if we could figure out a way to print the collection elements the same as regular fields. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)