You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2017/01/06 23:47:41 UTC
Review Request 55286: GEODE-2280: Allow accessors to create a lucene
index
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55286/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and Jason Huynh.
Repository: geode
Description
-------
Allow peer accessors to create a lucene index and fixing the dunit tests
to actually use an accessor.
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java f8bbc418955b7fb6102312325f0304cd385a0a7c
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 8e62c85896da8bef5684c71cda8dc13624feede4
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java ffab354f1c1ea030267fa21f4efd477004b622c8
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java b9aa0b781522e58ae6650e704e7ba4f9325ed99e
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java d645d5e357b3312c5501ca24abff40ceeaf93682
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java cec37343fe1b249cc767839a708229a6c9011881
Diff: https://reviews.apache.org/r/55286/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 55286: GEODE-2280: Allow accessors to create a
lucene index
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55286/#review160867
-----------------------------------------------------------
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java (line 63)
<https://reviews.apache.org/r/55286/#comment232118>
You will create file region and chunk region with PARTITION_PROXY too?
That's much easier than my original idea (i.e. not to create them)
- xiaojian zhou
On Jan. 6, 2017, 11:47 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55286/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 11:47 p.m.)
>
>
> Review request for geode, Barry Oglesby and Jason Huynh.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Allow peer accessors to create a lucene index and fixing the dunit tests
> to actually use an accessor.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java f8bbc418955b7fb6102312325f0304cd385a0a7c
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 8e62c85896da8bef5684c71cda8dc13624feede4
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java ffab354f1c1ea030267fa21f4efd477004b622c8
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java b9aa0b781522e58ae6650e704e7ba4f9325ed99e
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java d645d5e357b3312c5501ca24abff40ceeaf93682
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java cec37343fe1b249cc767839a708229a6c9011881
>
> Diff: https://reviews.apache.org/r/55286/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 55286: GEODE-2280: Allow accessors to create a
lucene index
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55286/#review160903
-----------------------------------------------------------
Ship it!
Looks good, was there no test originally for (the now removed) thrown exception?
- Jason Huynh
On Jan. 6, 2017, 11:47 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55286/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 11:47 p.m.)
>
>
> Review request for geode, Barry Oglesby and Jason Huynh.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Allow peer accessors to create a lucene index and fixing the dunit tests
> to actually use an accessor.
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java f8bbc418955b7fb6102312325f0304cd385a0a7c
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 8e62c85896da8bef5684c71cda8dc13624feede4
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRDUnitTest.java ffab354f1c1ea030267fa21f4efd477004b622c8
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java b9aa0b781522e58ae6650e704e7ba4f9325ed99e
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRRedundancyDUnitTest.java d645d5e357b3312c5501ca24abff40ceeaf93682
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java cec37343fe1b249cc767839a708229a6c9011881
>
> Diff: https://reviews.apache.org/r/55286/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>