You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/29 20:17:21 UTC
[jira] [Commented] (TWILL-177) ZKDiscoveryService should have a way
to remove its connection watcher
[ https://issues.apache.org/jira/browse/TWILL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446942#comment-15446942 ]
ASF GitHub Bot commented on TWILL-177:
--------------------------------------
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/8
(TWILL-177) Make ZKDiscoveryService AutoCloseable
- Release ZK watches when closed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/twill-177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/twill/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit 98bcb2d05b02b45bdf0937fb936befb558260b3b
Author: Terence Yim <ch...@apache.org>
Date: 2016-08-26T01:41:15Z
(TWILL-177) Make ZKDiscoveryService AutoCloseable
- Release ZK watches when closed
----
> ZKDiscoveryService should have a way to remove its connection watcher
> ---------------------------------------------------------------------
>
> Key: TWILL-177
> URL: https://issues.apache.org/jira/browse/TWILL-177
> Project: Apache Twill
> Issue Type: Bug
> Components: discovery
> Reporter: Albert Shau
> Assignee: Terence Yim
> Fix For: 0.8.0
>
>
> The ZKDiscoveryService adds a connection watcher in its constructor, but has no way to remove it. As a result, if somebody is creating new instances, the number of watches will slowly grow.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)