Re: [PATCH] Important Solaris Libthread Fix for Apache 1.3

[Jeff Trawick <tr...@bellsouth.net>]

"Jason Greene" <us...@tds.net> writes:

> This is a reposting of a fix that conforms to your posting rules.
> For a description of the problem this fixes see my posting called solaris + libthread + keepalive fix.
> I relize this patch will need to be modified slightly to be more compatible with other platforms.
> 
> Is there a possibility this could make the next release?

I think it best to see this enabled by -Dsomething in Configure for
solaris only, with "#ifdef something" around ap_reset_signal_mask()
and the call to it.  Clearly, most platforms don't need this (since
nobody has complained yet).

I will take on the task of testing your fix (using pthread
serialization on Solaris 8 for Intel) with the goal of committing it.
If I see breakage and your fix corrects it, I will commit it.  If I
see something else, I'll get back with you.  If somebody on this list
doesn't think this should be committed, all bets are off.

I can't promise that this will be 1.3.15...  Maybe you can get a
better offer from someone else :)

Thanks,

Jeff
-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Re: [PATCH] Important Solaris Libthread Fix for Apache 1.3

[Jeff Trawick <tr...@bellsouth.net>]

"Jason Greene" <us...@tds.net> writes:

> > I think it best to see this enabled by -Dsomething in Configure for
> > solaris only, with "#ifdef something" around ap_reset_signal_mask()
> > and the call to it.  Clearly, most platforms don't need this (since
> > nobody has complained yet).
> 
> I agree, possibly #ifdef SOLARIS2 ?
> I for sure, have never seen this happen on another platform.

Actually, I thought I would use "#ifdef NEED_RESET_SIGNAL_MASK" or
something like that in the source code, and in the Solaris logic in
Configure, add "-DNEED_RESET_SIGNAL_MASK" to CFLAGS... 

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Re: [PATCH] Important Solaris Libthread Fix for Apache 1.3

[Jason Greene <us...@tds.net>]

> I think it best to see this enabled by -Dsomething in Configure for
> solaris only, with "#ifdef something" around ap_reset_signal_mask()
> and the call to it.  Clearly, most platforms don't need this (since
> nobody has complained yet).

I agree, possibly #ifdef SOLARIS2 ?
I for sure, have never seen this happen on another platform.

> I will take on the task of testing your fix (using pthread
> serialization on Solaris 8 for Intel) with the goal of committing it.
> If I see breakage and your fix corrects it, I will commit it.  If I
> see something else, I'll get back with you.

Thanks for looking into it. Ya, if you could let me know your results that would be great.

>  If somebody on this list doesn't think this should be committed, all bets are off.

I agree, there is always the chance I missed an important aspect

> I can't promise that this will be 1.3.15...  Maybe you can get a
> better offer from someone else :)

Thats fine if it doesn't make it, I realize the release is just around the corner

Thanks,
Jason