You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/26 14:31:21 UTC
[GitHub] [airflow] ferruzzi opened a new pull request, #23256: Amazon Sagemaker Sample DAG and docs update
ferruzzi opened a new pull request, #23256:
URL: https://github.com/apache/airflow/pull/23256
Cleans up the existing sample DAG and docs for the SageMaker operators.
Part of a project to standardize AWS sample dags and docs in preparation for adding System Testing.
Related: https://github.com/apache/airflow/pull/21523
Related: https://github.com/apache/airflow/pull/21475
Related: https://github.com/apache/airflow/pull/21828
Related: https://github.com/apache/airflow/pull/21920
etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #23256: Amazon Sagemaker Sample DAG and docs update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on PR #23256:
URL: https://github.com/apache/airflow/pull/23256#issuecomment-1115286910
@eladkal may want eyes on this one since he has reviewed most.all of the others in this collection of changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #23256: Amazon Sagemaker Sample DAG and docs update
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on PR #23256:
URL: https://github.com/apache/airflow/pull/23256#issuecomment-1110044278
Please note: The operators have `do_xcom_push=False` because they currently fail at the very end with the message "Object of type datetime is not JSON serializable". This is a temporary workaround and can be fixed by adding json.dumps() to the return statements. For example: change `return self.hook.describe_endpoint_config(endpoint_info['EndpointConfigName'])` to `return json.dumps(self.hook.describe_endpoint_config(endpoint_info['EndpointConfigName']), cls=AirflowJsonEncoder)`.
I will submit a fix for those next, but that is outside the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23256: Amazon Sagemaker Sample DAG and docs update
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23256:
URL: https://github.com/apache/airflow/pull/23256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org