You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/30 14:06:53 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #924: fix: typo, `MangerApiExpect` should be `ManagerApiExpect`
nic-chen opened a new pull request #924:
URL: https://github.com/apache/apisix-dashboard/pull/924
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
fix typo that `MangerApiExpect` should be `ManagerApiExpect`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #924: fix: typo, `MangerApiExpect` should be `ManagerApiExpect`
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #924:
URL: https://github.com/apache/apisix-dashboard/pull/924#issuecomment-735810486
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/924?src=pr&el=h1) Report
> Merging [#924](https://codecov.io/gh/apache/apisix-dashboard/pull/924?src=pr&el=desc) (b32470a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/666e8a203d8dcc968b526154a01f6eb40b077103?el=desc) (666e8a2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/924?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #924 +/- ##
=======================================
Coverage 42.82% 42.82%
=======================================
Files 18 18
Lines 1289 1289
=======================================
Hits 552 552
Misses 645 645
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/924?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/924?src=pr&el=footer). Last update [666e8a2...b32470a](https://codecov.io/gh/apache/apisix-dashboard/pull/924?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #924: chore: typo, `MangerApiExpect` should be `ManagerApiExpect`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #924:
URL: https://github.com/apache/apisix-dashboard/pull/924#issuecomment-735817903
> bad first commit log, please fix it first
>
> 
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #924: chore: typo, `MangerApiExpect` should be `ManagerApiExpect`
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #924:
URL: https://github.com/apache/apisix-dashboard/pull/924#issuecomment-735847708
close, and will open a new pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed pull request #924: chore: typo, `MangerApiExpect` should be `ManagerApiExpect`
Posted by GitBox <gi...@apache.org>.
nic-chen closed pull request #924:
URL: https://github.com/apache/apisix-dashboard/pull/924
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org