You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org> on 2014/02/05 15:54:14 UTC
[jira] [Commented] (SANTUARIO-377) Proposed implementation change
for ResourceResolverSpi
[ https://issues.apache.org/jira/browse/SANTUARIO-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892161#comment-13892161 ]
Colm O hEigeartaigh commented on SANTUARIO-377:
-----------------------------------------------
Could you submit a patch for this change?
Colm.
> Proposed implementation change for ResourceResolverSpi
> ------------------------------------------------------
>
> Key: SANTUARIO-377
> URL: https://issues.apache.org/jira/browse/SANTUARIO-377
> Project: Santuario
> Issue Type: Improvement
> Components: Java
> Affects Versions: Java 2.0.0
> Reporter: Michael Haeusler
> Assignee: Colm O hEigeartaigh
> Fix For: Java 2.0.0
>
>
> I just migrated an application from Santuario 1.5.x to 2.0.0-rc1
> The migration was rather painless, which is good :)
> however I noticed one API change that would have been much more obvious if the implementation of org.apache.xml.security.utils.resolver.ResourceResolverSpi
> would be different.
> public boolean engineCanResolveURI(ResourceResolverContext context)
> and
> public XMLSignatureInput engineResolveURI(ResourceResolverContext context)
> both have a default implementation that just throws a UnsupportedOperationException.
> My proposal is to change these methods to be abstract methods.
> That way the compiler will immediately point out the API change when migrating.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)