You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/10/20 20:11:28 UTC
Review Request 39489: [Preview] Add handling of config chages to
Express Upgrade Pack for (primarily for 2.1->2.3)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-13407
https://issues.apache.org/jira/browse/AMBARI-13407
Repository: ambari
Description
-------
Managed to get Configure tasks properly parsed in non-rolling upgrade pack.
Collected all config changes that are going to be performed. Commented ones seem to be unneeded for 2.1->2.3 upgrade, but process should be very similar for 2.2->2.3 EU, so will move them there after discussion/comments.
Please feel free to point out any unnecessary/missing config changes. I did not find any runbook, so had to guess from existing upgrade packs.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
Diff: https://reviews.apache.org/r/39489/diff/
Testing
-------
As of now, stuck trying to initiate EU for 2.1->2.3 . UI does not expose that for stack 2.1. Will try issuing manual curl requests to add repo version, distribute bits and launch EU tomorrow.
Thanks,
Dmitro Lisnichenko
Re: Review Request 39489: Express Upgrade: Create other Upgrade Packs
and Config Packs
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/#review103451
-----------------------------------------------------------
Ship it!
Let's get this in, and if we miss anything, we can just add it as we keep testing.
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 32)
<https://reviews.apache.org/r/39489/#comment161510>
Right now, we may require all services to be up, as a way to ensure that they can actually start.
As we keep testing this, we may decide to relax those constraints.
I'm ok with an empty list for now, but we need to analyze the prechecks for the ones that make sense.
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 348)
<https://reviews.apache.org/r/39489/#comment161514>
Hopefully it won't be needed since Tez Service Check should copy the tarball, and so will HistoryServer Start, and even HiveServer Start.
If the services are up, then it doesn't hurt to call it.
- Alejandro Fernandez
On Oct. 21, 2015, 6:57 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39489/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 6:57 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13407
> https://issues.apache.org/jira/browse/AMBARI-13407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created missing upgrade packs based on existing EU/RU packs.
>
> Please feel free to point out any unnecessary/missing config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
>
> Diff: https://reviews.apache.org/r/39489/diff/
>
>
> Testing
> -------
>
> During EU, stages for non-existing services/components are also scheduled. That's why it's a big trouble to test new upgrade packs E2E.
> I'm going to get current patch in and open a separate jira to fix this behaviour.
>
> All other todos (left by me) are expected to be taken care of in next jiras.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 39489: Express Upgrade: Create other Upgrade Packs
and Config Packs
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/#review103543
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On Oct. 22, 2015, 8:32 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39489/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 8:32 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13407
> https://issues.apache.org/jira/browse/AMBARI-13407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Created missing upgrade packs based on existing EU/RU packs.
>
> Please feel free to point out any unnecessary/missing config changes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java 368bcb8
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml af2d1d9
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml af2d1d9
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml af2d1d9
>
> Diff: https://reviews.apache.org/r/39489/diff/
>
>
> Testing
> -------
>
> During EU, stages for non-existing services/components are also scheduled. That's why it's a big trouble to test new upgrade packs E2E.
> I'm going to get current patch in and open a separate jira to fix this behaviour.
>
> All other todos (left by me) are expected to be taken care of in next jiras.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 39489: Express Upgrade: Create other Upgrade Packs
and Config Packs
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/
-----------------------------------------------------------
(Updated Oct. 22, 2015, 11:32 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
Changes
-------
Merged with current 2.1 branch and addressed comments
Bugs: AMBARI-13407
https://issues.apache.org/jira/browse/AMBARI-13407
Repository: ambari
Description
-------
Created missing upgrade packs based on existing EU/RU packs.
Please feel free to point out any unnecessary/missing config changes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java 368bcb8
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml af2d1d9
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml af2d1d9
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml af2d1d9
Diff: https://reviews.apache.org/r/39489/diff/
Testing
-------
During EU, stages for non-existing services/components are also scheduled. That's why it's a big trouble to test new upgrade packs E2E.
I'm going to get current patch in and open a separate jira to fix this behaviour.
All other todos (left by me) are expected to be taken care of in next jiras.
Thanks,
Dmitro Lisnichenko
Re: Review Request 39489: Express Upgrade: Create other Upgrade Packs
and Config Packs
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/
-----------------------------------------------------------
(Updated Oct. 21, 2015, 9:57 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
Summary (updated)
-----------------
Express Upgrade: Create other Upgrade Packs and Config Packs
Bugs: AMBARI-13407
https://issues.apache.org/jira/browse/AMBARI-13407
Repository: ambari
Description (updated)
-------
Created missing upgrade packs based on existing EU/RU packs.
Please feel free to point out any unnecessary/missing config changes.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
Diff: https://reviews.apache.org/r/39489/diff/
Testing (updated)
-------
During EU, stages for non-existing services/components are also scheduled. That's why it's a big trouble to test new upgrade packs E2E.
I'm going to get current patch in and open a separate jira to fix this behaviour.
All other todos (left by me) are expected to be taken care of in next jiras.
Thanks,
Dmitro Lisnichenko
Re: Review Request 39489: [Preview] Add handling of config chages to
Express Upgrade Pack for (primarily for 2.1->2.3)
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/#review103298
-----------------------------------------------------------
Ship it!
I agree about all of the ranger stuff; you can remove it since it wasn't part of 2.1
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (lines 136 - 141)
<https://reviews.apache.org/r/39489/#comment161282>
I agree; I think this can be removed from this upgrade pack.
- Jonathan Hurley
On Oct. 20, 2015, 2:12 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39489/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 2:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13407
> https://issues.apache.org/jira/browse/AMBARI-13407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Managed to get Configure tasks properly parsed in non-rolling upgrade pack.
>
> Collected all config changes that are going to be performed. Commented ones seem to be unneeded for 2.1->2.3 upgrade, but process should be very similar for 2.2->2.3 EU, so will move them there after discussion/comments.
>
> Please feel free to point out any unnecessary/missing config changes. I did not find any runbook, so had to guess from existing upgrade packs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
>
> Diff: https://reviews.apache.org/r/39489/diff/
>
>
> Testing
> -------
>
> As of now, stuck trying to initiate EU for 2.1->2.3 . UI does not expose that for stack 2.1. Will try issuing manual curl requests to add repo version, distribute bits and launch EU tomorrow.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 39489: [Preview] Add handling of config chages to
Express Upgrade Pack for (primarily for 2.1->2.3)
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/#review103294
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Oct. 20, 2015, 2:12 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39489/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 2:12 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-13407
> https://issues.apache.org/jira/browse/AMBARI-13407
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Managed to get Configure tasks properly parsed in non-rolling upgrade pack.
>
> Collected all config changes that are going to be performed. Commented ones seem to be unneeded for 2.1->2.3 upgrade, but process should be very similar for 2.2->2.3 EU, so will move them there after discussion/comments.
>
> Please feel free to point out any unnecessary/missing config changes. I did not find any runbook, so had to guess from existing upgrade packs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
>
> Diff: https://reviews.apache.org/r/39489/diff/
>
>
> Testing
> -------
>
> As of now, stuck trying to initiate EU for 2.1->2.3 . UI does not expose that for stack 2.1. Will try issuing manual curl requests to add repo version, distribute bits and launch EU tomorrow.
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 39489: [Preview] Add handling of config chages to
Express Upgrade Pack for (primarily for 2.1->2.3)
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39489/
-----------------------------------------------------------
(Updated Oct. 20, 2015, 9:12 p.m.)
Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.
Changes
-------
Uploaded the correct patch
Bugs: AMBARI-13407
https://issues.apache.org/jira/browse/AMBARI-13407
Repository: ambari
Description
-------
Managed to get Configure tasks properly parsed in non-rolling upgrade pack.
Collected all config changes that are going to be performed. Commented ones seem to be unneeded for 2.1->2.3 upgrade, but process should be very similar for 2.2->2.3 EU, so will move them there after discussion/comments.
Please feel free to point out any unnecessary/missing config changes. I did not find any runbook, so had to guess from existing upgrade packs.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml 3778655
Diff: https://reviews.apache.org/r/39489/diff/
Testing
-------
As of now, stuck trying to initiate EU for 2.1->2.3 . UI does not expose that for stack 2.1. Will try issuing manual curl requests to add repo version, distribute bits and launch EU tomorrow.
Thanks,
Dmitro Lisnichenko