You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/20 13:11:12 UTC
[GitHub] [airflow] TobKed opened a new pull request #6865: [AIRFLOW-6314]
BigQuery - improve BigQueryHook test
TobKed opened a new pull request #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865
Move methods for BigQueryHook under one testings class
Add new tests
Improve mock assertions
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6314
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4982531ea322982eba7df47dc70c57099c9f9578?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38451 38454 +3
==========================================
- Hits 32517 32421 -96
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2JpZ3F1ZXJ5LnB5) | `84.43% <0%> (+0.04%)` | :arrow_up: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [4982531...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11ebe00c7b585f3819685177b8aad68c314c4d68?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.57% 84.31% -0.27%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32521 32421 -100
- Misses 5933 6033 +100
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [11ebe00...746035f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11ebe00c7b585f3819685177b8aad68c314c4d68?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.57% 84.31% -0.27%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32521 32421 -100
- Misses 5933 6033 +100
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [11ebe00...746035f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11ebe00c7b585f3819685177b8aad68c314c4d68?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.57% 84.31% -0.27%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32521 32421 -100
- Misses 5933 6033 +100
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [11ebe00...746035f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11ebe00c7b585f3819685177b8aad68c314c4d68?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.57% 84.31% -0.27%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32521 32421 -100
- Misses 5933 6033 +100
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [11ebe00...746035f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/4982531ea322982eba7df47dc70c57099c9f9578?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38451 38454 +3
==========================================
- Hits 32517 32421 -96
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/operators/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2JpZ3F1ZXJ5LnB5) | `84.43% <0%> (+0.04%)` | :arrow_up: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [4982531...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] TobKed commented on a change in pull request #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#discussion_r360638659
##########
File path: tests/gcp/hooks/test_bigquery.py
##########
@@ -56,21 +55,108 @@ def test_bigquery_client_creation(
)
self.assertEqual(mock_bigquery_connection.return_value, result)
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.base.CloudBaseHook.__init__")
+ def test_bigquery_bigquery_conn_id_deprecation_warning(
+ self, mock_base_hook_init, mock_get_creds_and_proj_id
+ ):
+ bigquery_conn_id = "bigquery conn id"
+ warning_message = "The bigquery_conn_id parameter has been deprecated. " \
+ "You should pass the gcp_conn_id parameter."
+ with self.assertWarns(DeprecationWarning) as warn:
+ hook.BigQueryHook(bigquery_conn_id=bigquery_conn_id)
+ mock_base_hook_init.assert_called_once_with(delegate_to=None, gcp_conn_id='bigquery conn id')
+ self.assertEqual(warning_message, str(warn.warning))
-class TestPandasGbqCredentials(unittest.TestCase):
@mock.patch(
'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
return_value=("CREDENTIALS", "PROJECT_ID",)
)
- @mock.patch('airflow.gcp.hooks.bigquery.read_gbq')
- def test_credentials_provided(self, mock_read_gbq, mock_get_creds_and_proj_id):
- self.instance = hook.BigQueryHook() # pylint: disable=attribute-defined-outside-init
+ def test_bigquery_insert_rows_not_implemented(self, mock_get_creds_and_proj_id):
+ bq_hook = hook.BigQueryHook()
+ with self.assertRaises(NotImplementedError):
+ bq_hook.insert_rows(table="table", rows=[1, 2])
- self.instance.get_pandas_df('select 1')
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.bigquery.BigQueryHook.get_service")
+ def test_bigquery_table_exists_true(self, mock_get_service, mock_get_creds_and_proj_id):
+ project_id = 'bq-project'
+ dataset_id = 'bq_dataset'
+ table_id = 'bq_table_view'
Review comment:
@nuclearpinguin PR mentioned in my previous comment was merged, I've rebased and adjusted slightly and now I think it looks like you suggested :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11ebe00c7b585f3819685177b8aad68c314c4d68?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.57% 84.31% -0.27%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32521 32421 -100
- Misses 5933 6033 +100
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [11ebe00...746035f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6865: [AIRFLOW-6314]
BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #6865: [AIRFLOW-6314]
BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] TobKed commented on a change in pull request #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#discussion_r360457310
##########
File path: tests/gcp/hooks/test_bigquery.py
##########
@@ -56,21 +55,108 @@ def test_bigquery_client_creation(
)
self.assertEqual(mock_bigquery_connection.return_value, result)
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.base.CloudBaseHook.__init__")
+ def test_bigquery_bigquery_conn_id_deprecation_warning(
+ self, mock_base_hook_init, mock_get_creds_and_proj_id
+ ):
+ bigquery_conn_id = "bigquery conn id"
+ warning_message = "The bigquery_conn_id parameter has been deprecated. " \
+ "You should pass the gcp_conn_id parameter."
+ with self.assertWarns(DeprecationWarning) as warn:
+ hook.BigQueryHook(bigquery_conn_id=bigquery_conn_id)
+ mock_base_hook_init.assert_called_once_with(delegate_to=None, gcp_conn_id='bigquery conn id')
+ self.assertEqual(warning_message, str(warn.warning))
-class TestPandasGbqCredentials(unittest.TestCase):
@mock.patch(
'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
return_value=("CREDENTIALS", "PROJECT_ID",)
)
- @mock.patch('airflow.gcp.hooks.bigquery.read_gbq')
- def test_credentials_provided(self, mock_read_gbq, mock_get_creds_and_proj_id):
- self.instance = hook.BigQueryHook() # pylint: disable=attribute-defined-outside-init
+ def test_bigquery_insert_rows_not_implemented(self, mock_get_creds_and_proj_id):
+ bq_hook = hook.BigQueryHook()
+ with self.assertRaises(NotImplementedError):
+ bq_hook.insert_rows(table="table", rows=[1, 2])
- self.instance.get_pandas_df('select 1')
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.bigquery.BigQueryHook.get_service")
+ def test_bigquery_table_exists_true(self, mock_get_service, mock_get_creds_and_proj_id):
+ project_id = 'bq-project'
+ dataset_id = 'bq_dataset'
+ table_id = 'bq_table_view'
Review comment:
I think it is good idea however I will address it in the another separate PR for the whole file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#discussion_r360408169
##########
File path: tests/gcp/hooks/test_bigquery.py
##########
@@ -56,21 +55,108 @@ def test_bigquery_client_creation(
)
self.assertEqual(mock_bigquery_connection.return_value, result)
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.base.CloudBaseHook.__init__")
+ def test_bigquery_bigquery_conn_id_deprecation_warning(
+ self, mock_base_hook_init, mock_get_creds_and_proj_id
+ ):
+ bigquery_conn_id = "bigquery conn id"
+ warning_message = "The bigquery_conn_id parameter has been deprecated. " \
+ "You should pass the gcp_conn_id parameter."
+ with self.assertWarns(DeprecationWarning) as warn:
+ hook.BigQueryHook(bigquery_conn_id=bigquery_conn_id)
+ mock_base_hook_init.assert_called_once_with(delegate_to=None, gcp_conn_id='bigquery conn id')
+ self.assertEqual(warning_message, str(warn.warning))
-class TestPandasGbqCredentials(unittest.TestCase):
@mock.patch(
'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
return_value=("CREDENTIALS", "PROJECT_ID",)
)
- @mock.patch('airflow.gcp.hooks.bigquery.read_gbq')
- def test_credentials_provided(self, mock_read_gbq, mock_get_creds_and_proj_id):
- self.instance = hook.BigQueryHook() # pylint: disable=attribute-defined-outside-init
+ def test_bigquery_insert_rows_not_implemented(self, mock_get_creds_and_proj_id):
+ bq_hook = hook.BigQueryHook()
+ with self.assertRaises(NotImplementedError):
+ bq_hook.insert_rows(table="table", rows=[1, 2])
- self.instance.get_pandas_df('select 1')
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.bigquery.BigQueryHook.get_service")
+ def test_bigquery_table_exists_true(self, mock_get_service, mock_get_creds_and_proj_id):
+ project_id = 'bq-project'
+ dataset_id = 'bq_dataset'
+ table_id = 'bq_table_view'
Review comment:
Maybe it's worth to convert those variables to constants? This will reduce boilerplate code ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/11ebe00c7b585f3819685177b8aad68c314c4d68?src=pr&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.57% 84.31% -0.27%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32521 32421 -100
- Misses 5933 6033 +100
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/contrib/operators/ssh\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zc2hfb3BlcmF0b3IucHk=) | `83.33% <0%> (-1.29%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [11ebe00...746035f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] TobKed commented on a change in pull request #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
TobKed commented on a change in pull request #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#discussion_r360488972
##########
File path: tests/gcp/hooks/test_bigquery.py
##########
@@ -56,21 +55,108 @@ def test_bigquery_client_creation(
)
self.assertEqual(mock_bigquery_connection.return_value, result)
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.base.CloudBaseHook.__init__")
+ def test_bigquery_bigquery_conn_id_deprecation_warning(
+ self, mock_base_hook_init, mock_get_creds_and_proj_id
+ ):
+ bigquery_conn_id = "bigquery conn id"
+ warning_message = "The bigquery_conn_id parameter has been deprecated. " \
+ "You should pass the gcp_conn_id parameter."
+ with self.assertWarns(DeprecationWarning) as warn:
+ hook.BigQueryHook(bigquery_conn_id=bigquery_conn_id)
+ mock_base_hook_init.assert_called_once_with(delegate_to=None, gcp_conn_id='bigquery conn id')
+ self.assertEqual(warning_message, str(warn.warning))
-class TestPandasGbqCredentials(unittest.TestCase):
@mock.patch(
'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
return_value=("CREDENTIALS", "PROJECT_ID",)
)
- @mock.patch('airflow.gcp.hooks.bigquery.read_gbq')
- def test_credentials_provided(self, mock_read_gbq, mock_get_creds_and_proj_id):
- self.instance = hook.BigQueryHook() # pylint: disable=attribute-defined-outside-init
+ def test_bigquery_insert_rows_not_implemented(self, mock_get_creds_and_proj_id):
+ bq_hook = hook.BigQueryHook()
+ with self.assertRaises(NotImplementedError):
+ bq_hook.insert_rows(table="table", rows=[1, 2])
- self.instance.get_pandas_df('select 1')
+ @mock.patch(
+ 'airflow.gcp.hooks.base.CloudBaseHook._get_credentials_and_project_id',
+ return_value=("CREDENTIALS", "PROJECT_ID",)
+ )
+ @mock.patch("airflow.gcp.hooks.bigquery.BigQueryHook.get_service")
+ def test_bigquery_table_exists_true(self, mock_get_service, mock_get_creds_and_proj_id):
+ project_id = 'bq-project'
+ dataset_id = 'bq_dataset'
+ table_id = 'bq_table_view'
Review comment:
@nuclearpinguin WDYT about https://github.com/apache/airflow/pull/6869 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6865:
[AIRFLOW-6314] BigQuery - improve BigQueryHook test
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6865: [AIRFLOW-6314] BigQuery - improve BigQueryHook test
URL: https://github.com/apache/airflow/pull/6865#issuecomment-567950157
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=h1) Report
> Merging [#6865](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/65ef8f3f810d90efa1d868f0bda460c0d13321f2?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 84.56% 84.31% -0.26%
==========================================
Files 680 680
Lines 38454 38454
==========================================
- Hits 32520 32421 -99
- Misses 5934 6033 +99
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6865/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (+1.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=footer). Last update [65ef8f3...ec01f8f](https://codecov.io/gh/apache/airflow/pull/6865?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services