You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "Forstwith (via GitHub)" <gi...@apache.org> on 2023/04/13 09:26:48 UTC
[GitHub] [skywalking-python] Forstwith opened a new pull request, #299: Fix sw8 loss when use aiohttp.
Forstwith opened a new pull request, #299:
URL: https://github.com/apache/skywalking-python/pull/299
Fix sw8 loss when use aiohttp.
In /plugins/sw_aiohttp.py
When headers is not MultiDictProxy or MultiDict , headers = CIMultiDict(headers) make the headers not the same object as kwargs['headers'] . Therefore, the carrier information is not added to the actual sent headers
```python
if headers is None:
headers = kwargs['headers'] = CIMultiDict()
elif not isinstance(headers, (MultiDictProxy, MultiDict)):
headers = CIMultiDict(headers)
kwargs['headers'] = headers # add this line to add headers back.
for item in carrier:
headers.add(item.key, item.val)
```
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <bug description or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] I have rebuilt the `Configuration.md` documentation by running `make doc-gen`
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
<!-- ==== π± Remove this line WHEN AND ONLY WHEN you're adding or modifying a plugin instrumentation, follow the checklist π ====
### <Feature description>
- [ ] If adding a new plugin, add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] If adding a new plugin, add a logo in [the UI repo](https://github.com/apache/skywalking-booster-ui/tree/main/src/assets/img/technologies)
- [ ] I have added the library to `pyproject.toml` (plugin group) by running `poetry add library --group plugins`
- [ ] I have rebuilt the `Plugins.md` documentation by running `make doc-gen`
==== π± Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue url. Closes:[ [<URL to main repo issue>](https://github.com/apache/skywalking/issues/10669)](https://github.com/apache/skywalking/issues/10669)
- [ ] Update the [`CHANGELOG.md`](https://github.com/apache/skywalking-python/blob/master/CHANGELOG.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Forstwith commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "Forstwith (via GitHub)" <gi...@apache.org>.
Forstwith commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1507942112
> HelloοΌyou should move the changelog to 1.1.0 as 1.0.0 was already released.
I saw that @wu-sheng has updated it for me, many thanks. I see that one of the unit tests is failing, is there anything I can do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Forstwith closed pull request #299: Fix sw8 loss when use aiohttp.
Posted by "Forstwith (via GitHub)" <gi...@apache.org>.
Forstwith closed pull request #299: Fix sw8 loss when use aiohttp.
URL: https://github.com/apache/skywalking-python/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1506777630
Why close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1506787181
You don't need to close/reopen, just update on your branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Forstwith commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "Forstwith (via GitHub)" <gi...@apache.org>.
Forstwith commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1506785346
> Why close?
I want to add a changelog, and then reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "Superskyyy (via GitHub)" <gi...@apache.org>.
Superskyyy commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1507344492
HelloοΌyou should move the changelog to 1.1.0 as 1.0.0 was already released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1506731376
You at least missed to update change log file.
Please read PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Forstwith commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "Forstwith (via GitHub)" <gi...@apache.org>.
Forstwith commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1506773882
> You at least missed to update change log file. Please read PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng merged pull request #299: Fix sw8 loss when use aiohttp.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #299:
URL: https://github.com/apache/skywalking-python/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Forstwith commented on pull request #299: Fix sw8 loss when use aiohttp.
Posted by "Forstwith (via GitHub)" <gi...@apache.org>.
Forstwith commented on PR #299:
URL: https://github.com/apache/skywalking-python/pull/299#issuecomment-1506837440
Yes, thanks for letting me know that I don't have to close/reopen. I've added the changelog, and reopened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org