You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by "bossenti (via GitHub)" <gi...@apache.org> on 2024/04/02 08:54:57 UTC

[I] User edit dialog expects username

bossenti opened a new issue, #2681:
URL: https://github.com/apache/streampipes/issues/2681

   ### Apache StreamPipes version
   
   dev (current development state)
   
   ### Affected StreamPipes components
   
   UI
   
   ### What happened?
   
   When editing a user in the user management, the dialog expects the user name to be provided.
   
   ![image](https://github.com/apache/streampipes/assets/50115603/8cf3ebab-f0e5-4795-9b2a-041a56d88248)
   
   This is an issue since the username is never present when the user was created through self-registration.
   
   ### How to reproduce?
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional technical information
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   No, I don't want to submit a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe closed issue #2681: User edit dialog expects username
URL: https://github.com/apache/streampipes/issues/2681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-2083808267

   In my opinion, we should probably keep it despite it's not currently used in code because users might want to know that attribute. For example, an assembly line may have multiple industrial/manufactural engineers who use StreamPipes and they/their admin might be interested in knowing who is who. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-3948891748

   @AliRana30 Sorry for the late reply, assigned


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-3718109769

   I forgot about this issue, @Hitaishi08 feel free to just take over. Looks that I can assign so I assigned to you. Lmk if you need anything. Thanks a lot for your help🙂!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "Hitaishi08 (via GitHub)" <gi...@apache.org>.
Hitaishi08 commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-3688834526

   Hello @bossenti
   I’m interested in working on this issue and would like to take it up.
   Kindly assign it to me if it’s available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-2084478271

   Yes, I agree. In mid-/longterm we might want to use it, especially if integrating SSO somewhen


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "muyangye (via GitHub)" <gi...@apache.org>.
muyangye commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-2080456690

   Hey @bossenti! This issue also occurs when some other admins want to edit the initial admin admin@streampipes.apache.org. I believe the expected behavior is that the username field is not required right? If so it's just a one-line change. I have found the line but since this change is so simple, maybe we should label it as a good-first-issue so that first time contributors can have a try? If nobody claimes it for say 2 months, I'll push the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-2081941700

   Good idea @muyangye, let's do it like that
   In addition, we can think of if we want to keep the property `Full Name` both in the UI and the data model. AFAIK, it is not used currently


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] User edit dialog expects username

Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on issue #2681:
URL: https://github.com/apache/streampipes/issues/2681#issuecomment-3929255743

   Hi @bossenti @muyangye — I noticed this issue is still open and the previous assignee hasn't been active for about 2 months. I've looked into it and based on the earlier discussion, the fix involves removing the **required** constraint from the username field in the user edit dialog, since users created via self-registration don't have a username stored.
   I'm interested in working on this. Could you re-assign this to me, or confirm it's still available?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org