You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2007/12/10 20:01:59 UTC
[jira] Created: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
[hbase] Implement "ALTER TABLE ... CHANGE column" operation
-----------------------------------------------------------
Key: HADOOP-2395
URL: https://issues.apache.org/jira/browse/HADOOP-2395
Project: Hadoop
Issue Type: Improvement
Components: contrib/hbase
Reporter: Bryan Duxbury
Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HADOOP-2395) [hbase] Implement "ALTER TABLE
... CHANGE column" operation
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HADOOP-2395 started by Bryan Duxbury.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned HADOOP-2395:
-------------------------------------
Assignee: Bryan Duxbury (was: Edward Yoon)
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550947 ]
Hudson commented on HADOOP-2395:
--------------------------------
Integrated in Hadoop-Nightly #330 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/330/])
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: stack
> Fix For: 0.16.0
>
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Edward Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward Yoon reassigned HADOOP-2395:
-----------------------------------
Assignee: Edward Yoon
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Edward Yoon
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550548 ]
Hadoop QA commented on HADOOP-2395:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371407/2395-v2.patch
against trunk revision r603084.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1318/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1318/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1318/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1318/console
This message is automatically generated.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: stack
> Fix For: 0.16.0
>
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Edward Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550294 ]
Edward Yoon commented on HADOOP-2395:
-------------------------------------
thanks, brayn. :-)
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2395:
----------------------------------
Status: Patch Available (was: In Progress)
Tests all pass locally, except for TestTableMapReduce, which seems unrelated.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HADOOP-2395:
-----------------------------
Assignee: stack (was: Bryan Duxbury)
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: stack
> Fix For: 0.16.0
>
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2395:
----------------------------------
Attachment: 2395-v2.patch
Added some help text, fixed the bug Stack was seeing (adding a : unconditionally).
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2395:
--------------------------
Fix Version/s: 0.16.0
Status: In Progress (was: Patch Available)
New patch works nicely.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.16.0
>
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2395:
--------------------------
Status: Patch Available (was: In Progress)
Passes tests locally. Forwarding to hudson.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: stack
> Fix For: 0.16.0
>
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated HADOOP-2395:
----------------------------------
Attachment: 2395.patch
Here's a patch. It adds the needed shell command implementation and modifies HBaseAdmin, HMaster, HMasterInterface to add the needed modifyColumn method.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550284 ]
Hadoop QA commented on HADOOP-2395:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12371395/2395.patch
against trunk revision r603084.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1312/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1312/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1312/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1312/console
This message is automatically generated.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550303 ]
stack commented on HADOOP-2395:
-------------------------------
This looks great Bryan.
Minor comment would be that things Strings such as "IN_MEMORY" should be made into defines since it seems to be used in a few places.
I tried it and got this exception (Its hard to figure what the format for the CHANGE column_spec should be -- maybe update the help string for ALTER in HelpCommand?):
{code}
hql > alter table 'x' CHANGE x: MAX_VERSIONS=4; Disabling x... Please wait.07/12/10 20:32:23 DEBUG hbase.HBaseAdmin: Sleep. Waiting for first region to be disabled from x
07/12/10 20:32:33 DEBUG hbase.HBaseAdmin: Wake. Waiting for first region to be disabled from x
07/12/10 20:32:33 INFO hbase.HBaseAdmin: Disabled table x
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -24
at java.lang.String.substring(String.java:1768)
at org.apache.hadoop.hbase.shell.BasicCommand.extractErrMsg(BasicCommand.java:64)
at org.apache.hadoop.hbase.shell.BasicCommand.extractErrMsg(BasicCommand.java:68)
at org.apache.hadoop.hbase.shell.AlterCommand.execute(AlterCommand.java:113)
at org.apache.hadoop.hbase.Shell.main(Shell.java:94)
durruti:~/Documents/checkouts/hadoop-trunk/src/contrib/hbase stack$ ./bin/hbase shell
07/12/10 20:33:46 DEBUG shell.TableFormatterFactory: Table formatter class: org.apache.hadoop.hbase.shell.formatter.AsciiTableFormatter
Hbase Shell, 0.0.2 version.
Copyright (c) 2007 by udanax, licensed to Apache Software Foundation.
Type 'help;' for usage.
hql > alter table 'x' CHANGE x: COMPRESSION=RECORD;
07/12/10 20:34:20 DEBUG hbase.HConnectionManager$TableServers: No servers for .META.. Doing a find...
07/12/10 20:34:20 DEBUG hbase.HConnectionManager$TableServers: Found 1 region(s) for .META. at address: 192.168.1.135:53538, regioninfo: regionname: -ROOT-,,0, startKey: <>, tableDesc: {name: -ROOT-, families: {info:={name: info, max versions: 1, compression: NONE, in memory: false, max length: 2147483647, bloom filter: none}}}
Disabling x... Please wait.
07/12/10 20:34:20 INFO hbase.HBaseAdmin: Disabled table x
Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -24
at java.lang.String.substring(String.java:1768)
at org.apache.hadoop.hbase.shell.BasicCommand.extractErrMsg(BasicCommand.java:64)
at org.apache.hadoop.hbase.shell.BasicCommand.extractErrMsg(BasicCommand.java:68)
at org.apache.hadoop.hbase.shell.AlterCommand.execute(AlterCommand.java:113)
at org.apache.hadoop.hbase.Shell.main(Shell.java:94)
~
{code}
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2395) [hbase] Implement "ALTER TABLE ...
CHANGE column" operation
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2395:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Resolving. Thanks for the patch Bryan.
> [hbase] Implement "ALTER TABLE ... CHANGE column" operation
> -----------------------------------------------------------
>
> Key: HADOOP-2395
> URL: https://issues.apache.org/jira/browse/HADOOP-2395
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: Bryan Duxbury
> Assignee: stack
> Fix For: 0.16.0
>
> Attachments: 2395-v2.patch, 2395.patch
>
>
> Right now, you can add or delete column families, but not change them once they are created. This is really inconvenient for things like adding compression or bloom filters to a column family once you get going. As new people come to HBase, they're going to make schema decisions that are incorrect and will need a way to modify their tables, so this is an important new feature.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.