Re: [PR] [INLONG-9866][Sort] Add end to end test case(redis to redis) for sort-connector-redis-v1.15. [inlong]

["EMsnap (via GitHub)" <gi...@apache.org>]

EMsnap commented on code in PR #9869:
URL: https://github.com/apache/inlong/pull/9869#discussion_r1546242229


##########
inlong-sort/sort-end-to-end-tests/sort-end-to-end-tests-v1.15/pom.xml:
##########
@@ -241,7 +254,7 @@
                         <goals>
                             <goal>copy</goal>
                         </goals>
-                        <phase>pre-integration-test</phase>
+                        <phase>validate</phase>

Review Comment:
   sorry but why change to validate ? 



##########
.github/workflows/ci_ut.yml:
##########
@@ -101,7 +101,7 @@ jobs:
           CI: false
 
       - name: Unit test with Maven
-        run: mvn --batch-mode --update-snapshots -e -V test
+        run: mvn --batch-mode --update-snapshots -e -V test -pl !:sort-end-to-end-tests-v1.15,!:sort-end-to-end-tests-v1.13

Review Comment:
   please add a pr later for end-to-end-test in flink1.13 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org