[GitHub] [cassandra-sidecar] rustyrazorblade commented on a change in pull request #18: CDC reader in Apache Cassandra Sidecar - CASSANDRASC-27

[GitBox <gi...@apache.org>]

rustyrazorblade commented on a change in pull request #18:
URL: https://github.com/apache/cassandra-sidecar/pull/18#discussion_r526488137



##########
File path: src/main/java/org/apache/cassandra/sidecar/MainModule.java
##########
@@ -126,6 +130,14 @@ public Router vertxRouter(Vertx vertx)
         return router;
     }
 
+    @Override
+    protected void  configure()
+    {
+        // TODO: Make the output type configurable
+        bind(CDCReaderMonitor.class).to(CDCReaderMonitorLogger.class);
+        bind(Output.class).to(ConsoleOutput.class);

Review comment:
       I'm not seeing an advantage to the request, @Maxwell-Guo.  The approach @tharanga took is pretty standard for a Guice binding.

##########
File path: build.gradle
##########
@@ -179,6 +179,7 @@ dependencies {
 
     compile project(":common")
     compile project(":cassandra40")
+    compile 'org.apache.cassandra:cassandra-all:4.0-beta2'

Review comment:
       If you take a look at the last commit I added, I spent a lot of time trying to decouple the sidecar from using a specific version of Cassandra.  Each version we decide to support can (and will) have an adapter, allowing us to maintain a single sidecar project that can work with different versions of Cassandra each of which has different implementations.  There's no assurance that C* 5.0 will have the same CDC implementation as the 4.0 version.  Could you please move the version specific logic into the cassandra40 subproject?
   
   In addition, we may want to have the user point to their cassandra lib directory as well in order to not ship every version of C* with the sidecar.  That will give us the flexibility for folks to use their own builds (private or public) as well as ship a smaller artifact.  Since everyone *has* to run Cassandra I think this is a fair ask.  Using a `compileOnly` dependency would allow us to test against each version of C* without shipping the jars.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org