You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/15 19:40:12 UTC

[GitHub] [lucenenet] nikcio opened a new issue, #678: Rename 'xxx' which hides the field with the same name

nikcio opened a new issue, #678:
URL: https://github.com/apache/lucenenet/issues/678

   Mentioned in #648 
   
   Issues found: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1117&id=nikcio_lucenenet
   
   We can fix this for the static readonly fields. In regular instance methods, we should leave it alone unless it diverges from Lucene.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Rename 'xxx' which hides the field with the same name [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin closed issue #678: Rename 'xxx' which hides the field with the same name
URL: https://github.com/apache/lucenenet/issues/678


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Rename 'xxx' which hides the field with the same name [lucenenet]

Posted by "paulirwin (via GitHub)" <gi...@apache.org>.
paulirwin commented on issue #678:
URL: https://github.com/apache/lucenenet/issues/678#issuecomment-2490057432

   I reviewed _all 206_ of these issues, and of those, only 15 were ones we should fix. The remaining were the same as in Lucene, so we should not fix it as it is too risky, as noted in this original issue text. I've marked the 191 items we won't fix as "Accepted" with a reason of "Matches Lucene." After discussion with @NightOwl888, we feel this is preferable to littering our code with suppressions. The remaining I'll get a PR for.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org