Re: [PR] Hive: Preserve transaction's pending encryption keys across repeated metadata refreshes [iceberg]

["smaheshwar-pltr (via GitHub)" <gi...@apache.org>]

smaheshwar-pltr commented on code in PR #18489:
URL: https://github.com/apache/iceberg/pull/18489#discussion_r4261991985


##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##########
@@ -173,9 +173,12 @@ void transactionCanReadAfterTableRefresh() {
     Transaction transaction = table.newTransaction();
     transaction.newFastAppend().appendFile(file).commit();
 
-    // Refresh must preserve the keys for the transaction's uncommitted snapshot.
     table.refresh();
 
+    // The open transaction must survive separate metadata commits.
+    table.updateProperties().set("owner", "alice").commit();
+    table.updateProperties().set("comment", "Updated description").commit();

Review Comment:
   I _could_ technically test this with double refreshes, but I'm using explicit commits instead (commits are useful for https://github.com/apache/iceberg/pull/13225#discussion_r4261895284 and probably more representative than manual double refresh). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org