[jira] [Commented] (ROCKETMQ-6) Use logger for exceptions instead of e.printStackTrace()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073397#comment-16073397 ] 

ASF GitHub Bot commented on ROCKETMQ-6:
---------------------------------------

Github user vongosling commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905067
  
    --- Diff: rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java ---
    @@ -101,7 +101,7 @@ public void stop(final boolean interrupt) {
     
         public void makeStop() {
             this.stopped = true;
    -        STLOG.info("makestop thread " + this.getServiceName());
    +        log.info("makestop thread " + this.getServiceName());
    --- End diff --
    
    the same 


> Use logger for exceptions instead of e.printStackTrace()
> --------------------------------------------------------
>
>                 Key: ROCKETMQ-6
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>             Fix For: 4.2.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules, except tests, tools and  examples.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)