You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by zhixinwen <gi...@git.apache.org> on 2017/11/14 05:42:16 UTC

[GitHub] helix pull request #:

Github user zhixinwen commented on the pull request:

    https://github.com/apache/helix/commit/384978a2e16ab0f4adb388e32c7e448c77996ca2#commitcomment-25598255
  
    In helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
    In helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java on line 122:
    Would this line cause [leaking _this_ in constructor](https://www.ibm.com/developerworks/java/library/j-jtp0618/index.html#2)? I am not completely sure, since the inner class has a hidden pointer to the outer class,  but [§12.5 ](https://docs.oracle.com/javase/specs/jls/se7/html/jls-12.html#jls-12.5)of the Java Language Specification (JLS) seems to have no special word about inner class.


---