[GitHub] rlevas commented on a change in pull request #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias Should be Configurable

[GitBox <gi...@apache.org>]

rlevas commented on a change in pull request #56: KNOX-1756 - Knox Gateway TLS Keystore and Alias Should be Configurable
URL: https://github.com/apache/knox/pull/56#discussion_r258985959
 
 

 ##########
 File path: gateway-provider-security-pac4j/src/main/java/org/apache/knox/gateway/pac4j/filter/Pac4jDispatcherFilter.java
 ##########
 @@ -190,8 +190,18 @@ private void addDefaultConfig(String clientNameParameter, Map<String, String> pr
       properties.put(PropertiesConfigFactory.SAML_KEYSTORE_PATH,
           keystoreService.getKeystorePath());
 
-      properties.put(PropertiesConfigFactory.SAML_KEYSTORE_PASSWORD,
-          new String(masterService.getMasterSecret()));
+      // check for provisioned alias for keystore password
+      char[] giksp = null;
 
 Review comment:
   It is possible, but I was trying to keep with the style of the file (and method impl) where `gip` (Gateway Identity Password) was already used.  In an effort to not add more lines to the patch, I left `giksp` and `gip` rather than changing both to `gatewayIdentityKeystorePassword` and `gatewayIdentityPassword` or `identityKeystorePassword` and `identityPassword`, or whatnot. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services