[GitHub] arpadboda commented on a change in pull request #462: MINIFICPP-695 - NanoFi Examples appear to be broken

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #462: MINIFICPP-695 - NanoFi Examples appear to be broken
URL: https://github.com/apache/nifi-minifi-cpp/pull/462#discussion_r242585621
 
 

 ##########
 File path: nanofi/include/api/nanofi.h
 ##########
 @@ -347,7 +371,7 @@ int get_content(const flow_file_record* ff, uint8_t* target, int size);
  * @param name name of the attribute
  * @return 0 on success, -1 otherwise (doesn't exist)
  **/
-uint8_t remove_attribute(flow_file_record*, char *key);
+int8_t remove_attribute(flow_file_record*, const char * key);
 
 Review comment:
   This didn't even link as the impl in the cpp file was written for
   ```
   const char * key
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services