You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Peter Vary <pv...@cloudera.com> on 2017/03/14 14:14:11 UTC
Review Request 57599: HIVE-16152 TestBeeLineDriver logging
improvements
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57599/
-----------------------------------------------------------
Review request for hive, Zoltan Haindrich, Naveen Gangam, Vihang Karajgaonkar, and Barna Zsombor Klara.
Bugs: HIVE-16152
https://issues.apache.org/jira/browse/HIVE-16152
Repository: hive-git
Description
-------
Enhances the error message when a test fails.
For the actual output see the jira.
Diffs
-----
itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java acc02eb
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java 49d6d24
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java b6eac89
Diff: https://reviews.apache.org/r/57599/diff/1/
Testing
-------
Manually tested various fail cases.
Collected the output in the jira
Thanks,
Peter Vary
Re: Review Request 57599: HIVE-16152 TestBeeLineDriver logging
improvements
Posted by Vihang Karajgaonkar <vi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57599/#review169583
-----------------------------------------------------------
Thanks Peter for the change. Overall LGTM. Just a few comments below.
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java
Lines 92 (patched)
<https://reviews.apache.org/r/57599/#comment241992>
Can we create static final for the debug string constants and use String.format() method instead?
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java
Line 89 (original), 110 (patched)
<https://reviews.apache.org/r/57599/#comment241993>
Nit: spell check
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java
Line 260 (original), 281 (patched)
<https://reviews.apache.org/r/57599/#comment241999>
Can we use a better extension to the file name? How about "beforeExecute.log" and "afterExecute.log"
itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java
Lines 64 (patched)
<https://reviews.apache.org/r/57599/#comment241996>
Isn't the command which errored out (lastSucessfulCommand + 1)?
- Vihang Karajgaonkar
On March 14, 2017, 2:14 p.m., Peter Vary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57599/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 2:14 p.m.)
>
>
> Review request for hive, Zoltan Haindrich, Naveen Gangam, Vihang Karajgaonkar, and Barna Zsombor Klara.
>
>
> Bugs: HIVE-16152
> https://issues.apache.org/jira/browse/HIVE-16152
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Enhances the error message when a test fails.
> For the actual output see the jira.
>
>
> Diffs
> -----
>
> itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java acc02eb
> itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java 49d6d24
> itests/util/src/main/java/org/apache/hive/beeline/qfile/QFileBeeLineClient.java b6eac89
>
>
> Diff: https://reviews.apache.org/r/57599/diff/1/
>
>
> Testing
> -------
>
> Manually tested various fail cases.
> Collected the output in the jira
>
>
> Thanks,
>
> Peter Vary
>
>