You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Cheolsoo Park <pi...@gmail.com> on 2014/03/01 00:50:24 UTC

Re: Review Request 18607: PIG-3784: Port more mini cluster tests to Tez

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18607/
-----------------------------------------------------------

(Updated Feb. 28, 2014, 11:50 p.m.)


Review request for pig, Daniel Dai and Rohini Palaniswamy.


Changes
-------

Incorporate Rohini's comment.


Repository: pig-git


Description
-------

This patch ports the following unit tests to Tez:
* TestPigContext.java
* TestPigStorage.java
* TestNestedForeach.java
* TestEvalPipeline.java	
* TestPigServer.java

The changes include-
1) Made all the mini-cluster tests run in both MR and Tez mode. I didn't convert any local mode tests to mini cluster tests.
2) Deleted tests that are related to ComparisonFunc in TestEvalPipeline because ComparisonFunc has been depreciated since 0.7 (http://wiki.apache.org/pig/Pig070IncompatibleChanges). In fact, I will open a jira to completely remove ComparisonFunc from trunk.
3) Moved testNonExistingSecondDirectoryInSkewJoin that was added by PIG-3469 from TestPigServer to TestSkewedJoin. In addition, the test wasn't complete itself, so I improved it.
4) Fixed warnings, whitespaces and indentations while touching these files. Please hide whitespace changes if that's distracting for review. 


Diffs (updated)
-----

  src/org/apache/pig/PigServer.java 4e52b24 
  test/org/apache/pig/test/TestCombiner.java 286a802 
  test/org/apache/pig/test/TestCustomPartitioner.java 6019ac8 
  test/org/apache/pig/test/TestEvalPipeline.java 4d2fc23 
  test/org/apache/pig/test/TestNestedForeach.java 352b3eb 
  test/org/apache/pig/test/TestPigContext.java 7a660ee 
  test/org/apache/pig/test/TestPigServer.java 3fc1d76 
  test/org/apache/pig/test/TestPigStorage.java b30fc00 
  test/org/apache/pig/test/TestSkewedJoin.java 0a7ba63 
  test/org/apache/pig/test/TestSplitStore.java 1855fe0 
  test/tez-tests 287a0b5 

Diff: https://reviews.apache.org/r/18607/diff/


Testing
-------

All the tests pass in both tez and mr mode.


Thanks,

Cheolsoo Park