[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #59: Logcxx-521

[GitBox <gi...@apache.org>]

ams-tschoening commented on pull request #59:
URL: https://github.com/apache/logging-log4cxx/pull/59#issuecomment-810923318


   > Dang... not sure how those spaces keep creeping in.[...]
   
   `.editorconfig` is the root cause most likely, that contains spaces for shell scripts and `CMakeLists.txt`:
   
   ```ini
   [*.sh]
   charset						= utf-8
   end_of_line					= lf
   indent_size					= 2
   indent_style				= space
   insert_final_newline		= true
   tab_width					= 2
   trim_trailing_whitespace	= true
   
   [CMakeLists.txt]
   charset						= utf-8
   end_of_line					= lf
   indent_size					= 2
   indent_style				= space
   insert_final_newline		= true
   tab_width					= 2
   trim_trailing_whitespace	= true
   ```
   
   Looking at the logs, you seem to have simply copied the block for shell scripts, maybe because some of those files didn't follow the other style guide then. In the easiest case it might get removed so that it's handled by `*`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org