You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/15 19:40:13 UTC
[GitHub] codecov-io commented on issue #3484: Fix the bug where time
conversion is skipped when incoming and outgoing time column name are the
same
codecov-io commented on issue #3484: Fix the bug where time conversion is skipped when incoming and outgoing time column name are the same
URL: https://github.com/apache/incubator-pinot/pull/3484#issuecomment-439164892
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=h1) Report
> Merging [#3484](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c9a4e60c44b9bc37e7c314d3d6bd8849042ca014?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `90.24%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3484 +/- ##
============================================
- Coverage 70.58% 70.57% -0.02%
Complexity 4 4
============================================
Files 999 998 -1
Lines 45669 45669
Branches 6109 6106 -3
============================================
- Hits 32236 32231 -5
+ Misses 11329 11324 -5
- Partials 2104 2114 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inkedin/pinot/common/utils/time/TimeConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi91dGlscy90aW1lL1RpbWVDb252ZXJ0ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `0 <0> (?)` | |
| [...t/core/data/recordtransformer/TimeTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvcmVjb3JkdHJhbnNmb3JtZXIvVGltZVRyYW5zZm9ybWVyLmphdmE=) | `94.11% <91.3%> (-5.89%)` | `0 <0> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
| [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L2FnZ3JlZ2F0aW9uL2Z1bmN0aW9uL2N1c3RvbW9iamVjdC9NaW5NYXhSYW5nZVBhaXIuamF2YQ==) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | |
| [...re/data/recordtransformer/DataTypeTransformer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvcmVjb3JkdHJhbnNmb3JtZXIvRGF0YVR5cGVUcmFuc2Zvcm1lci5qYXZh) | `75% <0%> (-10.72%)` | `0% <0%> (ø)` | |
| [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9PckJsb2NrRG9jSWRTZXQuamF2YQ==) | `84.9% <0%> (-9.44%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `80% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `60.6% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-pinot/pull/3484/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=footer). Last update [c9a4e60...a40b3b2](https://codecov.io/gh/apache/incubator-pinot/pull/3484?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org