You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/11/03 05:02:02 UTC

[GitHub] [calcite] libenchao commented on a diff in pull request #2952: [CALCITE-5252] JDBC adapter sometimes miss parentheses around SELECT in WITH_ITEM body

libenchao commented on code in PR #2952:
URL: https://github.com/apache/calcite/pull/2952#discussion_r1012495796


##########
core/src/main/java/org/apache/calcite/sql/SqlWithItem.java:
##########
@@ -97,7 +97,7 @@ private static class SqlWithItemOperator extends SqlSpecialOperator {
         withItem.columnList.unparse(writer, getLeftPrec(), getRightPrec());
       }
       writer.keyword("AS");
-      withItem.query.unparse(writer, 10, 10);
+      withItem.query.unparse(writer, 100, 100);

Review Comment:
   Then could you document why you choose `100`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org