You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/29 15:54:00 UTC

[GitHub] [hive] kasakrisz commented on a change in pull request #1154: HIVE-23728: Run metastore verification tests during precommit

kasakrisz commented on a change in pull request #1154:
URL: https://github.com/apache/hive/pull/1154#discussion_r566916606



##########
File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Mssql.java
##########
@@ -72,8 +72,9 @@ public String getInitialJdbcUrl(String hostAddress) {
   }
 
   @Override
-  public boolean isContainerReady(String logOutput) {
-    return logOutput.contains(
+  public boolean isContainerReady(ProcessResults pr) {
+    return pr.stdout

Review comment:
       Can `pr` or `pr.stdout` be null?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org