You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "cat-with-cat (via GitHub)" <gi...@apache.org> on 2024/10/24 14:06:25 UTC

[PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

cat-with-cat opened a new pull request, #42445:
URL: https://github.com/apache/doris/pull/42445

   ## Proposed changes
   
   Issue Number: close #40834 
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42445:
URL: https://github.com/apache/doris/pull/42445#discussion_r1843227989


##########
result.csv:
##########


Review Comment:
   dont upload this file



##########
tools/ssb-tools/bin/ssb-dbgen-linux.tar.gz:
##########


Review Comment:
   dont upload this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435550225

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 191587 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c5cd0a2f20559cbf3fcd531ad1c397fc428a2f3a, data reload: false
   
   query1	840	419	416	416
   query2	6229	2135	2080	2080
   query3	8684	191	212	191
   query4	34774	23876	23507	23507
   query5	4782	457	437	437
   query6	300	185	174	174
   query7	4211	313	312	312
   query8	286	240	223	223
   query9	9472	2697	2672	2672
   query10	451	250	247	247
   query11	18298	15312	15098	15098
   query12	153	97	101	97
   query13	1560	423	398	398
   query14	8994	6845	7137	6845
   query15	245	173	188	173
   query16	7821	507	484	484
   query17	1413	592	582	582
   query18	2096	311	314	311
   query19	260	167	165	165
   query20	128	113	115	113
   query21	208	106	110	106
   query22	4561	4598	4565	4565
   query23	35053	34491	33981	33981
   query24	11031	2774	2771	2771
   query25	632	416	393	393
   query26	1212	160	169	160
   query27	2336	278	296	278
   query28	7542	2450	2418	2418
   query29	846	428	421	421
   query30	268	162	157	157
   query31	1055	786	811	786
   query32	95	55	56	55
   query33	768	278	285	278
   query34	945	507	518	507
   query35	1022	899	871	871
   query36	1095	945	968	945
   query37	135	73	74	73
   query38	4304	4199	4299	4199
   query39	1482	1415	1396	1396
   query40	205	104	100	100
   query41	49	47	48	47
   query42	114	105	103	103
   query43	541	496	478	478
   query44	1213	810	820	810
   query45	187	168	166	166
   query46	1113	716	716	716
   query47	1893	1846	1829	1829
   query48	431	328	331	328
   query49	895	395	412	395
   query50	811	407	397	397
   query51	7136	6956	6980	6956
   query52	106	93	94	93
   query53	257	182	180	180
   query54	1149	428	414	414
   query55	82	78	79	78
   query56	273	244	262	244
   query57	1321	1209	1160	1160
   query58	215	197	196	196
   query59	3143	2980	3126	2980
   query60	271	237	242	237
   query61	101	101	99	99
   query62	816	680	662	662
   query63	213	189	187	187
   query64	3961	637	625	625
   query65	3338	3216	3225	3216
   query66	720	300	301	300
   query67	16035	15725	15713	15713
   query68	4721	551	569	551
   query69	420	261	259	259
   query70	1234	1161	1176	1161
   query71	325	263	263	263
   query72	6298	4010	4000	4000
   query73	774	374	361	361
   query74	10094	9006	8938	8938
   query75	3415	2645	2680	2645
   query76	2800	915	1018	915
   query77	378	271	265	265
   query78	10501	9584	9557	9557
   query79	1815	593	600	593
   query80	1098	442	432	432
   query81	581	241	239	239
   query82	635	119	116	116
   query83	233	132	137	132
   query84	250	66	71	66
   query85	1258	300	286	286
   query86	372	307	305	305
   query87	4770	4737	4568	4568
   query88	3246	2213	2195	2195
   query89	410	298	285	285
   query90	1963	188	193	188
   query91	133	101	101	101
   query92	61	46	47	46
   query93	2049	535	543	535
   query94	737	281	293	281
   query95	345	249	252	249
   query96	627	281	290	281
   query97	2918	2685	2725	2685
   query98	211	199	187	187
   query99	1587	1308	1314	1308
   Total cold run time: 298435 ms
   Total hot run time: 191587 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435564025

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.87 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c5cd0a2f20559cbf3fcd531ad1c397fc428a2f3a, data reload: false
   
   query1	0.03	0.04	0.04
   query2	0.08	0.04	0.03
   query3	0.22	0.06	0.06
   query4	1.63	0.11	0.10
   query5	0.41	0.39	0.40
   query6	1.17	0.65	0.67
   query7	0.02	0.01	0.02
   query8	0.04	0.03	0.03
   query9	0.58	0.51	0.50
   query10	0.55	0.53	0.55
   query11	0.15	0.11	0.10
   query12	0.14	0.11	0.11
   query13	0.61	0.59	0.59
   query14	2.75	2.71	2.72
   query15	0.89	0.81	0.83
   query16	0.39	0.38	0.37
   query17	1.02	1.06	1.07
   query18	0.21	0.20	0.21
   query19	1.98	1.90	2.00
   query20	0.02	0.01	0.01
   query21	15.37	0.59	0.58
   query22	2.80	1.85	1.42
   query23	17.26	0.92	0.93
   query24	3.16	0.57	1.29
   query25	0.23	0.20	0.08
   query26	0.44	0.12	0.14
   query27	0.05	0.04	0.04
   query28	10.59	1.10	1.08
   query29	12.58	3.31	3.28
   query30	0.24	0.06	0.05
   query31	2.86	0.39	0.37
   query32	3.28	0.46	0.46
   query33	2.96	3.05	3.02
   query34	17.07	4.46	4.48
   query35	4.43	4.44	4.50
   query36	0.66	0.47	0.50
   query37	0.08	0.06	0.06
   query38	0.05	0.03	0.03
   query39	0.04	0.02	0.03
   query40	0.16	0.13	0.13
   query41	0.07	0.02	0.02
   query42	0.03	0.03	0.02
   query43	0.04	0.03	0.03
   Total cold run time: 107.34 s
   Total hot run time: 31.87 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2488324993

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 40271 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8acb29ae438731fc4018126b4f1e1a8dfd49ca23, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17595	7475	7403	7403
   q2	2037	173	169	169
   q3	10596	1107	1136	1107
   q4	10579	740	749	740
   q5	7613	2747	2694	2694
   q6	244	146	146	146
   q7	996	631	614	614
   q8	9247	1874	1907	1874
   q9	6545	6393	6394	6393
   q10	6993	2312	2352	2312
   q11	462	263	265	263
   q12	432	222	226	222
   q13	17781	3072	3086	3072
   q14	242	214	214	214
   q15	576	533	521	521
   q16	657	596	587	587
   q17	975	542	529	529
   q18	7135	6819	6761	6761
   q19	1334	949	1044	949
   q20	465	181	184	181
   q21	4040	3403	3202	3202
   q22	394	318	326	318
   Total cold run time: 106938 ms
   Total hot run time: 40271 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7400	7402	7378	7378
   q2	332	230	233	230
   q3	2930	2905	3033	2905
   q4	2059	1828	1877	1828
   q5	5672	5717	5709	5709
   q6	230	141	139	139
   q7	2251	1828	1843	1828
   q8	3446	3621	3563	3563
   q9	8971	8904	8942	8904
   q10	3629	3596	3583	3583
   q11	615	516	513	513
   q12	814	611	626	611
   q13	10418	3244	3242	3242
   q14	322	280	278	278
   q15	585	512	521	512
   q16	694	659	640	640
   q17	1862	1643	1616	1616
   q18	8417	7865	7588	7588
   q19	1761	1482	1561	1482
   q20	2116	1892	1910	1892
   q21	5719	5570	5507	5507
   q22	657	633	590	590
   Total cold run time: 70900 ms
   Total hot run time: 60538 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2488366123

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.07 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8acb29ae438731fc4018126b4f1e1a8dfd49ca23, data reload: false
   
   query1	0.04	0.03	0.03
   query2	0.07	0.04	0.03
   query3	0.23	0.09	0.08
   query4	1.61	0.10	0.10
   query5	0.44	0.40	0.41
   query6	1.16	0.67	0.66
   query7	0.03	0.02	0.01
   query8	0.04	0.03	0.04
   query9	0.56	0.52	0.50
   query10	0.56	0.54	0.57
   query11	0.14	0.10	0.10
   query12	0.14	0.11	0.11
   query13	0.60	0.60	0.60
   query14	2.79	2.71	2.78
   query15	0.88	0.84	0.83
   query16	0.41	0.38	0.40
   query17	1.07	1.01	1.03
   query18	0.20	0.19	0.21
   query19	1.85	1.88	2.02
   query20	0.01	0.01	0.01
   query21	15.36	0.58	0.57
   query22	2.54	2.88	1.38
   query23	16.91	1.00	0.87
   query24	2.89	1.45	0.86
   query25	0.31	0.06	0.20
   query26	0.37	0.15	0.13
   query27	0.05	0.05	0.04
   query28	10.51	1.09	1.07
   query29	12.53	3.19	3.17
   query30	0.25	0.06	0.06
   query31	2.87	0.40	0.38
   query32	3.26	0.46	0.47
   query33	2.97	3.01	3.17
   query34	16.90	4.50	4.52
   query35	4.58	4.52	4.52
   query36	0.68	0.49	0.49
   query37	0.09	0.06	0.06
   query38	0.05	0.04	0.03
   query39	0.03	0.03	0.02
   query40	0.15	0.12	0.12
   query41	0.07	0.02	0.02
   query42	0.03	0.02	0.02
   query43	0.03	0.03	0.04
   Total cold run time: 106.26 s
   Total hot run time: 32.07 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2466817912

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11767137905") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 148:
       printf "%s scale is NOT supported currently\n" "$SCALE_FACTOR"
                                                       ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       printf "%s scale is NOT supported currently\n" "${SCALE_FACTOR}"
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 106:
       printf "Error: Failed to drop the database %s.\n" "$DB" >&2
                                                          ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       printf "Error: Failed to drop the database %s.\n" "${DB}" >&2
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 111:
       printf "Error: Failed to create the database %s.\n" "$DB" >&2
                                                            ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       printf "Error: Failed to create the database %s.\n" "${DB}" >&2
   
   For more information:
     https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on code in PR #42445:
URL: https://github.com/apache/doris/pull/42445#discussion_r1839332050


##########
tools/ssb-tools/bin/run-ssb-queries.sh:
##########
@@ -120,19 +123,31 @@ for i in '1.1' '1.2' '1.3' '2.1' '2.2' '2.3' '3.1' '3.2' '3.3' '3.4' '4.1' '4.2'
     hot2=0
     echo -ne "q${i}\t" | tee -a result.csv
     start=$(date +%s%3N)
-    mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
+    if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
+        <"${QUERIES_DIR}/q${i}.sql" >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then

Review Comment:
   maybe don't use the log file, just printing the errmsg to console is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2476961903

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11841952838") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   'shellcheck ' found no issues.
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -136,7 +136,7 @@
        fi
        if ! grep_output=$(grep " Value: " <<<"${output}" 2>&1); then
            grep_status=$?
   -        # shellcheck disable=SC2292       
   +        # shellcheck disable=SC2292
            if [ "${grep_status}" -eq 2 ]; then
                printf "%s\n" "${grep_output}" >&2
                printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435397580

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11501010617") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In create-clickbench-table.sh line 27:
     cd "$ROOT"
         ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     cd "${ROOT}"
   
   
   In create-clickbench-table.sh line 43:
     -n $0 \
        ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
     -n "$0" \
   
   
   In create-clickbench-table.sh line 47:
   eval set -- "$OPTS"
                ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   eval set -- "${OPTS}"
   
   
   In create-clickbench-table.sh line 50:
   if [ $# == 0 ]; then
      ^---------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ $# == 0 ]]; then
   
   
   In create-clickbench-table.sh line 73:
     exit
     ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In create-clickbench-table.sh line 79:
     if ! $CMD; then
          ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     if ! ${CMD}; then
   
   
   In create-clickbench-table.sh line 80:
       echo "$NAME is missing. This script depends on mysql to create tables in Doris."
             ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "${NAME} is missing. This script depends on mysql to create tables in Doris."
   
   
   In create-clickbench-table.sh line 87:
   source $CURDIR/conf/doris-cluster.conf
          ^-----------------------------^ SC1091 (info): Not following: ./conf/doris-cluster.conf: openBinaryFile: does not exist (No such file or directory)
          ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
          ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   source "${CURDIR}"/conf/doris-cluster.conf
   
   
   In create-clickbench-table.sh line 88:
   echo "FE_HOST: $FE_HOST"
                  ^------^ SC2154 (warning): FE_HOST is referenced but not assigned.
                  ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "FE_HOST: ${FE_HOST}"
   
   
   In create-clickbench-table.sh line 89:
   echo "FE_QUERY_PORT: $FE_QUERY_PORT"
                        ^------------^ SC2154 (warning): FE_QUERY_PORT is referenced but not assigned.
                        ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "FE_QUERY_PORT: ${FE_QUERY_PORT}"
   
   
   In create-clickbench-table.sh line 90:
   echo "USER: $USER"
               ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "USER: ${USER}"
   
   
   In create-clickbench-table.sh line 91:
   echo "PASSWORD: $PASSWORD"
                   ^-------^ SC2154 (warning): PASSWORD is referenced but not assigned.
                   ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "PASSWORD: ${PASSWORD}"
   
   
   In create-clickbench-table.sh line 92:
   echo "DB: $DB"
             ^-^ SC2154 (warning): DB is referenced but not assigned.
             ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "DB: ${DB}"
   
   
   In create-clickbench-table.sh line 94:
   OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -e "CREATE DATABASE IF NOT EXISTS $DB")
                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                       ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                                                        ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   OUTPUT=$(mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -e "CREATE DATABASE IF NOT EXISTS ${DB}")
   
   
   In create-clickbench-table.sh line 95:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In create-clickbench-table.sh line 96:
     echo "Error: Failed to create database: $DB"
                                             ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     echo "Error: Failed to create database: ${DB}"
   
   
   In create-clickbench-table.sh line 97:
     echo "mysql error message: $OUTPUT"
                                ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     echo "mysql error message: ${OUTPUT}"
   
   
   In create-clickbench-table.sh line 100:
   OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB <$CURDIR/sql/create-clickbench-table.sql)
                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                       ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                             ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                             ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   OUTPUT=$(mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" <"${CURDIR}"/sql/create-clickbench-table.sql)
   
   
   In create-clickbench-table.sh line 101:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In create-clickbench-table.sh line 103:
     echo "mysql error message: $OUTPUT"
                                ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     echo "mysql error message: ${OUTPUT}"
   
   
   In create-clickbench-table.sh line 106:
   OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "show create table hits;")
                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                               ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                       ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                        ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                        ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   OUTPUT=$(mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e "show create table hits;")
   
   
   In create-clickbench-table.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In create-clickbench-table.sh line 108:
     echo "Error:  Failed to execute 'show create table hits;' in database $DB."
                                                                           ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     echo "Error:  Failed to execute 'show create table hits;' in database ${DB}."
   
   
   In create-clickbench-table.sh line 109:
     echo "mysql error message: $OUTPUT"
                                ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     echo "mysql error message: ${OUTPUT}"
   
   
   In load-clickbench-data.sh line 27:
       cd "$ROOT"
           ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       cd "${ROOT}"
   
   
   In load-clickbench-data.sh line 32:
   DATA_DIR=$CURDIR/
            ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   DATA_DIR=${CURDIR}/
   
   
   In load-clickbench-data.sh line 50:
       -n $0 \
          ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
       -n "$0" \
   
   
   In load-clickbench-data.sh line 54:
   eval set -- "$OPTS"
                ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   eval set -- "${OPTS}"
   
   
   In load-clickbench-data.sh line 87:
       if ! $CMD; then
            ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ! ${CMD}; then
   
   
   In load-clickbench-data.sh line 88:
           echo "$NAME is missing. This script depends on cURL to load data to Doris."
                 ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           echo "${NAME} is missing. This script depends on cURL to load data to Doris."
   
   
   In load-clickbench-data.sh line 97:
   source $CURDIR/conf/doris-cluster.conf
          ^-----------------------------^ SC1091 (info): Not following: ./conf/doris-cluster.conf: openBinaryFile: does not exist (No such file or directory)
          ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
          ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   source "${CURDIR}"/conf/doris-cluster.conf
   
   
   In load-clickbench-data.sh line 101:
   echo "FE_HOST: $FE_HOST"
                  ^------^ SC2154 (warning): FE_HOST is referenced but not assigned.
                  ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "FE_HOST: ${FE_HOST}"
   
   
   In load-clickbench-data.sh line 102:
   echo "FE_HTTP_PORT: $FE_HTTP_PORT"
                       ^-----------^ SC2154 (warning): FE_HTTP_PORT is referenced but not assigned.
                       ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "FE_HTTP_PORT: ${FE_HTTP_PORT}"
   
   
   In load-clickbench-data.sh line 103:
   echo "USER: $USER"
               ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "USER: ${USER}"
   
   
   In load-clickbench-data.sh line 104:
   echo "PASSWORD: $PASSWORD"
                   ^-------^ SC2154 (warning): PASSWORD is referenced but not assigned.
                   ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "PASSWORD: ${PASSWORD}"
   
   
   In load-clickbench-data.sh line 105:
   echo "DB: $DB"
             ^-^ SC2154 (warning): DB is referenced but not assigned.
             ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "DB: ${DB}"
   
   
   In load-clickbench-data.sh line 108:
       cv=$(mysql -h$FE_HOST -P$FE_QUERY_PORT -u$USER -e 'admin show frontend config' | grep 'stream_load_default_timeout_second' | awk '{print $2}')
                    ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                    ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                               ^------------^ SC2154 (warning): FE_QUERY_PORT is referenced but not assigned.
                               ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       cv=$(mysql -h"${FE_HOST}" -P"${FE_QUERY_PORT}" -u"${USER}" -e 'admin show frontend config' | grep 'stream_load_default_timeout_second' | awk '{print $2}')
   
   
   In load-clickbench-data.sh line 125:
       if (($cv < 3600)); then
            ^-^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
            ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ((${cv} < 3600)); then
   
   
   In load-clickbench-data.sh line 129:
       cv=$(curl "${BE_HOST}:${BE_WEBSERVER_PORT}/varz" 2>/dev/null | grep 'streaming_load_max_mb' | awk -F'=' '{print $2}')
                  ^--------^ SC2154 (warning): BE_HOST is referenced but not assigned.
                             ^------------------^ SC2154 (warning): BE_WEBSERVER_PORT is referenced but not assigned.
   
   
   In load-clickbench-data.sh line 146:
       if (($cv < 16000)); then
            ^-^ SC2004 (style): $/${} is unnecessary on arithmetic variables.
            ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ((${cv} < 16000)); then
   
   
   In load-clickbench-data.sh line 153:
       need_download=false
       ^-----------^ SC2034 (warning): need_download appears unused. Verify use (or export if used externally).
   
   
   In load-clickbench-data.sh line 154:
       cd $DATA_DIR
          ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
          ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       cd "${DATA_DIR}"
   
   
   In load-clickbench-data.sh line 156:
           if [ ! -f "$DATA_DIR/hits_split${i}" ]; then
              ^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                      ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           if [[ ! -f "${DATA_DIR}/hits_split${i}" ]]; then
   
   
   In load-clickbench-data.sh line 157:
               echo "will download hits_split${i} to $DATA_DIR"
                                                     ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               echo "will download hits_split${i} to ${DATA_DIR}"
   
   
   In load-clickbench-data.sh line 160:
               wget_pids[${#wget_pids[@]}]=$PID
                                           ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               wget_pids[${#wget_pids[@]}]=${PID}
   
   
   In load-clickbench-data.sh line 168:
       echo "(2/2) load clickbench data file $DATA_DIR/hits_split[0-9] into Doris"
                                             ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "(2/2) load clickbench data file ${DATA_DIR}/hits_split[0-9] into Doris"
   
   
   In load-clickbench-data.sh line 174:
                   -u $USER:$PASSWORD \
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
                   -u "${USER}":"${PASSWORD}" \
   
   
   In load-clickbench-data.sh line 175:
                   -T "$DATA_DIR/hits_split${i}" \
                       ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
                   -T "${DATA_DIR}/hits_split${i}" \
   
   
   In load-clickbench-data.sh line 177:
                   http://$FE_HOST:$FE_HTTP_PORT/api/$DB/hits/_stream_load
                          ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                     ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
                   http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/"${DB}"/hits/_stream_load
   
   
   In load-clickbench-data.sh line 180:
                   -u $USER:$PASSWORD \
                      ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                            ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                            ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
                   -u "${USER}":"${PASSWORD}" \
   
   
   In load-clickbench-data.sh line 181:
                   -T "$DATA_DIR/hits_split${i}" \
                       ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
                   -T "${DATA_DIR}/hits_split${i}" \
   
   
   In load-clickbench-data.sh line 184:
                   http://$FE_HOST:$FE_HTTP_PORT/api/$DB/hits/_stream_load
                          ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                   ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                   ^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                     ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                     ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
                   http://"${FE_HOST}":"${FE_HTTP_PORT}"/api/"${DB}"/hits/_stream_load
   
   
   In load-clickbench-data.sh line 191:
       for PID in ${wget_pids[@]}; do
                  ^-------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements.
   
   
   In load-clickbench-data.sh line 192:
           kill -9 $PID
                   ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                   ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           kill -9 "${PID}"
   
   
   In load-clickbench-data.sh line 206:
     echo $@
          ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.
   
   
   In load-clickbench-data.sh line 207:
     OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$@")
                      ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                      ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                         ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     OUTPUT=$(mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e "$@")
   
   
   In load-clickbench-data.sh line 208:
     if [[ $? -ne 0 ]]; then
           ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In load-clickbench-data.sh line 210:
       echo "mysql error message: $OUTPUT"
                                  ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "mysql error message: ${OUTPUT}"
   
   
   In run-clickbench-queries.sh line 27:
     cd "$ROOT"
         ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     cd "${ROOT}"
   
   
   In run-clickbench-queries.sh line 32:
   QUERIES_FILE=$CURDIR/sql/queries.sql
                ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   QUERIES_FILE=${CURDIR}/sql/queries.sql
   
   
   In run-clickbench-queries.sh line 44:
     -n $0 \
        ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
     -n "$0" \
   
   
   In run-clickbench-queries.sh line 49:
   eval set -- "$OPTS"
                ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   eval set -- "${OPTS}"
   
   
   In run-clickbench-queries.sh line 52:
   if [ $# == 0 ]; then
      ^---------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ $# == 0 ]]; then
   
   
   In run-clickbench-queries.sh line 75:
     exit
     ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In run-clickbench-queries.sh line 81:
     if ! $CMD; then
          ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     if ! ${CMD}; then
   
   
   In run-clickbench-queries.sh line 82:
       echo "$NAME is missing. This script depends on mysql to create tables in Doris."
             ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "${NAME} is missing. This script depends on mysql to create tables in Doris."
   
   
   In run-clickbench-queries.sh line 90:
   source $CURDIR/conf/doris-cluster.conf
          ^-----------------------------^ SC1091 (info): Not following: ./conf/doris-cluster.conf: openBinaryFile: does not exist (No such file or directory)
          ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
          ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   source "${CURDIR}"/conf/doris-cluster.conf
   
   
   In run-clickbench-queries.sh line 91:
   export MYSQL_PWD=$PASSWORD
                    ^-------^ SC2154 (warning): PASSWORD is referenced but not assigned.
                    ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   export MYSQL_PWD=${PASSWORD}
   
   
   In run-clickbench-queries.sh line 93:
   echo "FE_HOST: $FE_HOST"
                  ^------^ SC2154 (warning): FE_HOST is referenced but not assigned.
                  ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "FE_HOST: ${FE_HOST}"
   
   
   In run-clickbench-queries.sh line 94:
   echo "FE_QUERY_PORT: $FE_QUERY_PORT"
                        ^------------^ SC2154 (warning): FE_QUERY_PORT is referenced but not assigned.
                        ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "FE_QUERY_PORT: ${FE_QUERY_PORT}"
   
   
   In run-clickbench-queries.sh line 95:
   echo "USER: $USER"
               ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "USER: ${USER}"
   
   
   In run-clickbench-queries.sh line 96:
   echo "PASSWORD: $PASSWORD"
                   ^-------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "PASSWORD: ${PASSWORD}"
   
   
   In run-clickbench-queries.sh line 97:
   echo "DB: $DB"
             ^-^ SC2154 (warning): DB is referenced but not assigned.
             ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
   echo "DB: ${DB}"
   
   
   In run-clickbench-queries.sh line 100:
     echo $@
          ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.
   
   
   In run-clickbench-queries.sh line 101:
     OUTPUT=(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$@")
                     ^------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
                     ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                ^---^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
                                ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                        ^------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
                                        ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                         ^-^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.
                                                         ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     OUTPUT=(mysql -h${FE_HOST} -u${USER} -P${FE_QUERY_PORT} -D${DB} -e "$@")
   
   
   In run-clickbench-queries.sh line 102:
     if [[ $? -ne 0 ]]; then
           ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In run-clickbench-queries.sh line 104:
       echo "mysql error message: $OUTPUT"
                                  ^-----^ SC2128 (warning): Expanding an array without an index only gives the first element.
                                  ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "mysql error message: ${OUTPUT}"
   
   
   In run-clickbench-queries.sh line 139:
   cat ${QUERIES_FILE} | while read query; do
       ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                               ^--^ SC2162 (info): read without -r will mangle backslashes.
   
   Did you mean: 
   cat "${QUERIES_FILE}" | while read query; do
   
   
   In run-clickbench-queries.sh line 140:
     if [[ ! $query == SELECT* ]]; then
             ^----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     if [[ ! ${query} == SELECT* ]]; then
   
   
   In run-clickbench-queries.sh line 147:
     for i in $(seq 1 $TRIES); do
                      ^----^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                      ^----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
     for i in $(seq 1 "${TRIES}"); do
   
   
   In run-clickbench-queries.sh line 148:
       RES=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "${query}" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
                          ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                          ^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                     ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                     ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                             ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                              ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       RES=$(mysql -vvv -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e "${query}" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
   
   
   In run-clickbench-queries.sh line 157:
       [[ "$i" != $TRIES ]] && echo -n "," | tee -a result.csv
           ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                  ^----^ SC2053 (warning): Quote the right-hand side of != in [[ ]] to prevent glob matching.
                  ^----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       [[ "${i}" != ${TRIES} ]] && echo -n "," | tee -a result.csv
   
   
   In tools/ssb-tools/bin/load-ssb-data.sh line 116:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/load-ssb-data.sh line 117:
           echo "Error: Failed to execute the SQL command: $@"
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: $@"
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: $@"
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 156:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 161:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/load-tpcds-data.sh line 225:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 125:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 161:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 196:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 206:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 216:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/load-tpch-data.sh line 313:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 183:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 193:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 203:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
     https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
     https://www.shellcheck.net/wiki/SC2034 -- need_download appears unused. Ver...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- create-clickbench-table.sh.orig
   +++ create-clickbench-table.sh
   @@ -24,62 +24,62 @@
    
    ROOT=$(dirname "$0")
    ROOT=$(
   -  cd "$ROOT"
   -  pwd
   +    cd "$ROOT"
   +    pwd
    )
    
    CURDIR=${ROOT}
    
    usage() {
   -  echo "
   +    echo "
    This script is used to create ClickBench table, 
    will use mysql client to connect Doris server which is specified in conf/doris-cluster.conf file.
    Usage: $0 
      "
   -  exit 1
   +    exit 1
    }
    
    OPTS=$(getopt \
   -  -n $0 \
   -  -o '' \
   -  -- "$@")
   +    -n $0 \
   +    -o '' \
   +    -- "$@")
    
    eval set -- "$OPTS"
    HELP=0
    
    if [ $# == 0 ]; then
   -  usage
   +    usage
    fi
    
    while true; do
   -  case "$1" in
   -  -h)
   -    HELP=1
   -    shift
   -    ;;
   -  --)
   -    shift
   -    break
   -    ;;
   -  *)
   -    echo "Internal error"
   -    exit 1
   -    ;;
   -  esac
   +    case "$1" in
   +    -h)
   +        HELP=1
   +        shift
   +        ;;
   +    --)
   +        shift
   +        break
   +        ;;
   +    *)
   +        echo "Internal error"
   +        exit 1
   +        ;;
   +    esac
    done
    
    if [[ "${HELP}" -eq 1 ]]; then
   -  usage
   -  exit
   +    usage
   +    exit
    fi
    
    check_prerequest() {
   -  local CMD=$1
   -  local NAME=$2
   -  if ! $CMD; then
   -    echo "$NAME is missing. This script depends on mysql to create tables in Doris."
   -    exit 1
   -  fi
   +    local CMD=$1
   +    local NAME=$2
   +    if ! $CMD; then
   +        echo "$NAME is missing. This script depends on mysql to create tables in Doris."
   +        exit 1
   +    fi
    }
    
    check_prerequest "mysql --version" "mysql"
   @@ -93,21 +93,21 @@
    
    OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -e "CREATE DATABASE IF NOT EXISTS $DB")
    if [[ $? -ne 0 ]]; then
   -  echo "Error: Failed to create database: $DB"
   -  echo "mysql error message: $OUTPUT"
   -  exit 1
   +    echo "Error: Failed to create database: $DB"
   +    echo "mysql error message: $OUTPUT"
   +    exit 1
    fi
    OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB <$CURDIR/sql/create-clickbench-table.sql)
    if [[ $? -ne 0 ]]; then
   -  echo "Error:  Failed to execute the SQL script"
   -  echo "mysql error message: $OUTPUT"
   -  exit 1
   +    echo "Error:  Failed to execute the SQL script"
   +    echo "mysql error message: $OUTPUT"
   +    exit 1
    fi
    OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "show create table hits;")
    if [[ $? -ne 0 ]]; then
   -  echo "Error:  Failed to execute 'show create table hits;' in database $DB."
   -  echo "mysql error message: $OUTPUT"
   -  exit 1
   +    echo "Error:  Failed to execute 'show create table hits;' in database $DB."
   +    echo "mysql error message: $OUTPUT"
   +    exit 1
    fi
    
    echo "DONE."
   --- load-clickbench-data.sh.orig
   +++ load-clickbench-data.sh
   @@ -142,7 +142,7 @@
            echo "Error: Failed to extract the value using awk."
            exit 1
        fi
   -    
   +
        if (($cv < 16000)); then
            echo -e "advise: revise your Doris BE's conf to set 'streaming_load_max_mb=16000' or above and 'flush_thread_num_per_store=5' to speed up load."
        fi
   @@ -203,13 +203,13 @@
    echo "load cost time: $((end - start)) seconds"
    
    run_sql() {
   -  echo $@
   -  OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$@")
   -  if [[ $? -ne 0 ]]; then
   -    echo "Error: Failed to execute the SQL command"
   -    echo "mysql error message: $OUTPUT"
   -    exit 1
   -fi
   +    echo $@
   +    OUTPUT=$(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$@")
   +    if [[ $? -ne 0 ]]; then
   +        echo "Error: Failed to execute the SQL command"
   +        echo "mysql error message: $OUTPUT"
   +        exit 1
   +    fi
    }
    
    echo '============================================'
   --- run-clickbench-queries.sh.orig
   +++ run-clickbench-queries.sh
   @@ -24,64 +24,64 @@
    
    ROOT=$(dirname "$0")
    ROOT=$(
   -  cd "$ROOT"
   -  pwd
   +    cd "$ROOT"
   +    pwd
    )
    
    CURDIR=${ROOT}
    QUERIES_FILE=$CURDIR/sql/queries.sql
    
    usage() {
   -  echo "
   +    echo "
    This script is used to run ClickBench 43 queries, 
    will use mysql client to connect Doris server which parameter is specified in conf/doris-cluster.conf file.
    Usage: $0 
      "
   -  exit 1
   +    exit 1
    }
    
    OPTS=$(getopt \
   -  -n $0 \
   -  -o '' \
   -  -o 'h' \
   -  -- "$@")
   +    -n $0 \
   +    -o '' \
   +    -o 'h' \
   +    -- "$@")
    
    eval set -- "$OPTS"
    HELP=0
    
    if [ $# == 0 ]; then
   -  usage
   +    usage
    fi
    
    while true; do
   -  case "$1" in
   -  -h)
   -    HELP=1
   -    shift
   -    ;;
   -  --)
   -    shift
   -    break
   -    ;;
   -  *)
   -    echo "Internal error"
   -    exit 1
   -    ;;
   -  esac
   +    case "$1" in
   +    -h)
   +        HELP=1
   +        shift
   +        ;;
   +    --)
   +        shift
   +        break
   +        ;;
   +    *)
   +        echo "Internal error"
   +        exit 1
   +        ;;
   +    esac
    done
    
    if [[ "${HELP}" -eq 1 ]]; then
   -  usage
   -  exit
   +    usage
   +    exit
    fi
    
    check_prerequest() {
   -  local CMD=$1
   -  local NAME=$2
   -  if ! $CMD; then
   -    echo "$NAME is missing. This script depends on mysql to create tables in Doris."
   -    exit 1
   -  fi
   +    local CMD=$1
   +    local NAME=$2
   +    if ! $CMD; then
   +        echo "$NAME is missing. This script depends on mysql to create tables in Doris."
   +        exit 1
   +    fi
    }
    
    check_prerequest "mysql --version" "mysql"
   @@ -97,31 +97,31 @@
    echo "DB: $DB"
    
    run_sql() {
   -  echo $@
   -  OUTPUT=(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$@")
   -  if [[ $? -ne 0 ]]; then
   -    echo "Error: Failed to execute the SQL command"
   -    echo "mysql error message: $OUTPUT"
   -    exit 1
   -  fi
   +    echo $@
   +    OUTPUT=(mysql -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "$@")
   +    if [[ $? -ne 0 ]]; then
   +        echo "Error: Failed to execute the SQL command"
   +        echo "mysql error message: $OUTPUT"
   +        exit 1
   +    fi
    }
    
    get_session_variable() {
   -  k="$1"
   -  v=$(mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e"show variables like '${k}'\G" | grep " Value: ")
   +    k="$1"
   +    v=$(mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e"show variables like '${k}'\G" | grep " Value: ")
    
   -  if [[ ${PIPESTATUS[0]} -ne 0 ]]; then
   -    echo "Error: Failed to execute SQL command: show variables like '${k}'\G"
   -    exit 1
   -  fi
   -  if [[ ${PIPESTATUS[1]} -eq 1 ]]; then
   -    echo "Warning: No lines containing ' Value: ' were found."
   -    exit 1
   -  elif [[ ${PIPESTATUS[1]} -eq 2 ]]; then
   -    echo "Error: An error occurred while running grep."
   -    exit 1
   -  fi
   -  echo "${v/*Value: /}"
   +    if [[ ${PIPESTATUS[0]} -ne 0 ]]; then
   +        echo "Error: Failed to execute SQL command: show variables like '${k}'\G"
   +        exit 1
   +    fi
   +    if [[ ${PIPESTATUS[1]} -eq 1 ]]; then
   +        echo "Warning: No lines containing ' Value: ' were found."
   +        exit 1
   +    elif [[ ${PIPESTATUS[1]} -eq 2 ]]; then
   +        echo "Error: An error occurred while running grep."
   +        exit 1
   +    fi
   +    echo "${v/*Value: /}"
    }
    
    _exec_mem_limit="$(get_session_variable exec_mem_limit)"
   @@ -137,28 +137,28 @@
    truncate -s0 result.csv
    
    cat ${QUERIES_FILE} | while read query; do
   -  if [[ ! $query == SELECT* ]]; then
   -    continue
   -  fi
   -  sync
   -  echo 3 | sudo tee /proc/sys/vm/drop_caches >/dev/null
   -
   -  echo -n "query${QUERY_NUM}," | tee -a result.csv
   -  for i in $(seq 1 $TRIES); do
   -    RES=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "${query}" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
   -    if [[ ${PIPESTATUS[0]} -ne 0 ]]; then
   -      echo "Error: Failed to execute SQL command: ${query}"
   -      exit 1
   -    elif [[ ${PIPESTATUS[1]} -ne 0 ]]; then
   -      echo "Error: "
   +    if [[ ! $query == SELECT* ]]; then
   +        continue
        fi
   +    sync
   +    echo 3 | sudo tee /proc/sys/vm/drop_caches >/dev/null
    
   -    echo -n "${RES}" | tee -a result.csv
   -    [[ "$i" != $TRIES ]] && echo -n "," | tee -a result.csv
   -  done
   -  echo "" | tee -a result.csv
   +    echo -n "query${QUERY_NUM}," | tee -a result.csv
   +    for i in $(seq 1 $TRIES); do
   +        RES=$(mysql -vvv -h$FE_HOST -u$USER -P$FE_QUERY_PORT -D$DB -e "${query}" | perl -nle 'print $1 if /\((\d+\.\d+)+ sec\)/' || :)
   +        if [[ ${PIPESTATUS[0]} -ne 0 ]]; then
   +            echo "Error: Failed to execute SQL command: ${query}"
   +            exit 1
   +        elif [[ ${PIPESTATUS[1]} -ne 0 ]]; then
   +            echo "Error: "
   +        fi
    
   -  QUERY_NUM=$((QUERY_NUM + 1))
   +        echo -n "${RES}" | tee -a result.csv
   +        [[ "$i" != $TRIES ]] && echo -n "," | tee -a result.csv
   +    done
   +    echo "" | tee -a result.csv
   +
   +    QUERY_NUM=$((QUERY_NUM + 1))
    done
    
    cold_run_sum=$(awk -F ',' '{sum+=$2} END {print sum}' result.csv)
   --- tools/ssb-tools/bin/load-ssb-data.sh.orig
   +++ tools/ssb-tools/bin/load-ssb-data.sh
   @@ -396,4 +396,3 @@
    totalTime=$((end - start))
    echo "analyze database ${DB} with full with sync total time: ${totalTime} s"
    echo '============================================'
   -
   --- tools/ssb-tools/bin/run-ssb-flat-queries.sh.orig
   +++ tools/ssb-tools/bin/run-ssb-flat-queries.sh
   @@ -168,4 +168,3 @@
    echo "Total cold run time: ${cold_run_sum} ms"
    echo "Total hot run time: ${best_hot_run_sum} ms"
    echo 'Finish ssb-flat queries.'
   -
   --- tools/ssb-tools/bin/run-ssb-queries.sh.orig
   +++ tools/ssb-tools/bin/run-ssb-queries.sh
   @@ -168,4 +168,3 @@
    echo "Total cold run time: ${cold_run_sum} ms"
    echo "Total hot run time: ${best_hot_run_sum} ms"
    echo 'Finish ssb queries.'
   -
   --- tools/tpcds-tools/bin/create-tpcds-tables.sh.orig
   +++ tools/tpcds-tools/bin/create-tpcds-tables.sh
   @@ -118,28 +118,28 @@
        echo "Run SQLs from ${CURDIR}/../ddl/create-tpcds-tables-sf1.sql"
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" <"${CURDIR}"/../ddl/create-tpcds-tables-sf1.sql
        if [[ $? -ne 0 ]]; then
   -        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf1.sql" 
   +        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf1.sql"
            exit 1
        fi
    elif [[ ${SCALE_FACTOR} -eq 100 ]]; then
        echo "Run SQLs from ${CURDIR}/../ddl/create-tpcds-tables-sf100.sql"
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" <"${CURDIR}"/../ddl/create-tpcds-tables-sf100.sql
        if [[ $? -ne 0 ]]; then
   -        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf100.sql" 
   +        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf100.sql"
            exit 1
        fi
    elif [[ ${SCALE_FACTOR} -eq 1000 ]]; then
        echo "Run SQLs from ${CURDIR}/../ddl/create-tpcds-tables-sf1000.sql"
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" <"${CURDIR}"/../ddl/create-tpcds-tables-sf1000.sql
        if [[ $? -ne 0 ]]; then
   -        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf1000.sql" 
   +        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf1000.sql"
            exit 1
        fi
    elif [[ ${SCALE_FACTOR} -eq 10000 ]]; then
        echo "Run SQLs from ${CURDIR}/../ddl/create-tpcds-tables-sf10000.sql"
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" <"${CURDIR}"/../ddl/create-tpcds-tables-sf10000.sql
        if [[ $? -ne 0 ]]; then
   -        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf10000.sql" 
   +        echo "Error: Failed to execute the SQL script: create-tpcds-tables-sf10000.sql"
            exit 1
        fi
    else
   @@ -164,4 +164,3 @@
    fi
    
    echo "tpcds tables has been created"
   -
   --- tools/tpcds-tools/bin/load-tpcds-data.sh.orig
   +++ tools/tpcds-tools/bin/load-tpcds-data.sh
   @@ -223,8 +223,8 @@
        echo "$*"
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" -e "$*"
        if [[ $? -ne 0 ]]; then
   -    echo "Error: Failed to execute the SQL command: $*"
   -    exit 1
   +        echo "Error: Failed to execute the SQL command: $*"
   +        exit 1
        fi
    }
    start=$(date +%s)
   @@ -233,4 +233,3 @@
    analyzeTime=$((end - start))
    echo "analyze database ${DB} with full with sync total time: ${analyzeTime} s"
    echo '============================================'
   -
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -238,4 +238,3 @@
    echo 'Finish tpcds queries.'
    
    clean_up
   -
   --- tools/tpch-tools/bin/create-tpch-tables.sh.orig
   +++ tools/tpch-tools/bin/create-tpch-tables.sh
   @@ -142,4 +142,3 @@
    fi
    
    echo "tpch tables has been created"
   -
   --- tools/tpch-tools/bin/load-tpch-data.sh.orig
   +++ tools/tpch-tools/bin/load-tpch-data.sh
   @@ -321,4 +321,3 @@
    totalTime=$((end - start))
    echo "analyze database ${DB} with full with sync total time: ${totalTime} s"
    echo '============================================'
   -
   --- tools/tpch-tools/bin/run-tpch-queries.sh.orig
   +++ tools/tpch-tools/bin/run-tpch-queries.sh
   @@ -228,4 +228,3 @@
    echo "Restore session variables"
    run_sql "source ${backup_session_variables_file};"
    rm -f "${backup_session_variables_file}"
   -
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2488234664

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #42445:
URL: https://github.com/apache/doris/pull/42445


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437372335

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11515982463") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: '$@'"
                                                            ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: '$@'"
                                                            ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 156:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 161:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/load-tpcds-data.sh line 225:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 125:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 162:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 197:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 207:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 217:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/load-tpch-data.sh line 313:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 184:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 194:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 204:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
     https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/ssb-tools/bin/run-ssb-flat-queries.sh.orig
   +++ tools/ssb-tools/bin/run-ssb-flat-queries.sh
   @@ -127,7 +127,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue  
   +        continue
        fi
        end=$(date +%s%3N)
        cold=$((end - start))
   @@ -147,7 +147,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue  
   +        continue
        fi
        end=$(date +%s%3N)
        hot2=$((end - start))
   --- tools/ssb-tools/bin/run-ssb-queries.sh.orig
   +++ tools/ssb-tools/bin/run-ssb-queries.sh
   @@ -127,7 +127,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        cold=$((end - start))
   @@ -137,7 +137,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot1=$((end - start))
   @@ -147,7 +147,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot2=$((end - start))
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -196,7 +196,7 @@
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCDS_QUERIES_DIR}"/query"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        cold=$((end - start))
   @@ -206,7 +206,7 @@
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCDS_QUERIES_DIR}"/query"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot1=$((end - start))
   @@ -216,7 +216,7 @@
        mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCDS_QUERIES_DIR}"/query"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot2=$((end - start))
   --- tools/tpch-tools/bin/run-tpch-queries.sh.orig
   +++ tools/tpch-tools/bin/run-tpch-queries.sh
   @@ -183,7 +183,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        cold=$((end - start))
   @@ -193,7 +193,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot1=$((end - start))
   @@ -203,7 +203,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot2=$((end - start))
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435395916

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2476930727

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11841722832") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 141:
           if [ $grep_status -eq 2 ]; then
              ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           if [[ "${grep_status}" -eq 2 ]]; then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 143:
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
                                                                                                                    ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                                                                                                   ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 145:
           elif [ $grep_status -eq 1 ]; then
                ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                  ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                  ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           elif [[ "${grep_status}" -eq 1 ]]; then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 146:
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "$k" >&2
                                                                                                               ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 153:
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "$k" >&2
                                                                                                     ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 158:
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "$k" >&2
                                                                                                          ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 137:
           if [ $grep_status -eq 2 ]; then
              ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           if [[ "${grep_status}" -eq 2 ]]; then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 139:
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
                                                                                                                    ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                                                                                                   ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 141:
           elif [ $grep_status -eq 1 ]; then
                ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                  ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                  ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           elif [[ "${grep_status}" -eq 1 ]]; then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 142:
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "$k" >&2
                                                                                                               ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 149:
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "$k" >&2
                                                                                                     ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 154:
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "$k" >&2
                                                                                                          ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "${k}" >&2
   
   For more information:
     https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when v...
     https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
     https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -137,7 +137,7 @@
    
        if ! grep_output=$(grep " Value: " <<<"${output}" 2>&1); then
            grep_status=$?
   -        
   +
            if [ $grep_status -eq 2 ]; then
                printf "%s\n" "${grep_output}" >&2
                printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2488306261

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2488351423

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 196768 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8acb29ae438731fc4018126b4f1e1a8dfd49ca23, data reload: false
   
   query1	1221	928	972	928
   query2	6246	2230	2162	2162
   query3	10946	4090	4271	4090
   query4	67402	28766	23741	23741
   query5	4985	490	447	447
   query6	411	194	203	194
   query7	5534	298	291	291
   query8	320	221	220	220
   query9	8948	2693	2672	2672
   query10	457	254	253	253
   query11	17352	15510	15801	15510
   query12	154	105	108	105
   query13	1519	415	421	415
   query14	10383	7793	7262	7262
   query15	200	181	201	181
   query16	7077	425	464	425
   query17	1049	564	544	544
   query18	1772	282	296	282
   query19	189	150	141	141
   query20	117	109	111	109
   query21	230	101	100	100
   query22	4640	4354	4161	4161
   query23	34545	33999	34155	33999
   query24	5348	2491	2388	2388
   query25	480	390	371	371
   query26	646	150	152	150
   query27	1689	289	277	277
   query28	4350	2444	2397	2397
   query29	671	412	412	412
   query30	214	143	144	143
   query31	981	776	819	776
   query32	79	60	58	58
   query33	461	286	275	275
   query34	919	501	522	501
   query35	842	723	715	715
   query36	1101	978	946	946
   query37	122	76	74	74
   query38	4429	4275	4295	4275
   query39	1465	1429	1435	1429
   query40	203	106	104	104
   query41	48	48	47	47
   query42	118	100	99	99
   query43	555	514	496	496
   query44	1137	811	830	811
   query45	184	178	167	167
   query46	1138	697	709	697
   query47	1922	1845	1842	1842
   query48	420	312	322	312
   query49	760	414	447	414
   query50	803	385	407	385
   query51	7248	7053	7111	7053
   query52	102	92	87	87
   query53	258	178	179	178
   query54	513	408	386	386
   query55	76	78	73	73
   query56	250	240	238	238
   query57	1314	1171	1165	1165
   query58	218	217	223	217
   query59	3325	3411	3282	3282
   query60	251	244	245	244
   query61	125	104	112	104
   query62	762	701	701	701
   query63	221	188	182	182
   query64	1389	692	629	629
   query65	3316	3226	3211	3211
   query66	710	314	309	309
   query67	16192	15627	15715	15627
   query68	4125	576	562	562
   query69	425	253	261	253
   query70	1204	1114	1128	1114
   query71	365	253	261	253
   query72	6500	4064	4049	4049
   query73	761	362	352	352
   query74	10374	8954	9012	8954
   query75	3429	2724	2697	2697
   query76	1686	1014	1060	1014
   query77	479	296	284	284
   query78	10509	9543	9488	9488
   query79	1925	594	608	594
   query80	1097	424	442	424
   query81	545	227	229	227
   query82	219	122	126	122
   query83	185	153	152	152
   query84	284	69	67	67
   query85	990	298	290	290
   query86	416	302	293	293
   query87	4804	4716	4700	4700
   query88	4076	2222	2199	2199
   query89	427	298	299	298
   query90	2066	192	187	187
   query91	132	104	107	104
   query92	67	50	49	49
   query93	2529	549	547	547
   query94	944	303	308	303
   query95	344	243	246	243
   query96	639	279	285	279
   query97	2884	2709	2693	2693
   query98	222	192	203	192
   query99	2034	1325	1306	1306
   Total cold run time: 319738 ms
   Total hot run time: 196768 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2470936039

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11801106371") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 141:
           if [ $grep_status -eq 2 ]; then
              ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           if [[ "${grep_status}" -eq 2 ]]; then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 143:
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
                                                                                                                    ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                                                                                                   ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 145:
           elif [ $grep_status -eq 1 ]; then
                ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                  ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                  ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           elif [[ "${grep_status}" -eq 1 ]]; then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 146:
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "$k" >&2
                                                                                                               ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 153:
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "$k" >&2
                                                                                                     ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 158:
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "$k" >&2
                                                                                                          ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 137:
           if [ $grep_status -eq 2 ]; then
              ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           if [[ "${grep_status}" -eq 2 ]]; then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 139:
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
                                                                                                                    ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
                                                                                                                                   ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 141:
           elif [ $grep_status -eq 1 ]; then
                ^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
                  ^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
                  ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           elif [[ "${grep_status}" -eq 1 ]]; then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 142:
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "$k" >&2
                                                                                                               ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
               printf "Warning: No match for 'Value: ' found in the output of the query for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 149:
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "$k" >&2
                                                                                                     ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: awk command failed while processing the grep output for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 154:
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "$k" >&2
                                                                                                          ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Warning: No value found for variable '%s'. The 'Value:' might be missing or empty.\n" "${k}" >&2
   
   For more information:
     https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when v...
     https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
     https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests i...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -137,7 +137,7 @@
    
        if ! grep_output=$(grep " Value: " <<<"${output}" 2>&1); then
            grep_status=$?
   -        
   +
            if [ $grep_status -eq 2 ]; then
                printf "%s\n" "${grep_output}" >&2
                printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "$grep_status" "$k" >&2
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437445707

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11516572292") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: '$@'"
                                                            ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: '$@'"
                                                            ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 156:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 161:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/load-tpcds-data.sh line 225:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 125:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 162:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 197:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 207:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 217:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/load-tpch-data.sh line 313:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 184:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 194:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 204:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
     https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/ssb-tools/bin/run-ssb-flat-queries.sh.orig
   +++ tools/ssb-tools/bin/run-ssb-flat-queries.sh
   @@ -127,7 +127,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue  
   +        continue
        fi
        end=$(date +%s%3N)
        cold=$((end - start))
   @@ -147,7 +147,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue  
   +        continue
        fi
        end=$(date +%s%3N)
        hot2=$((end - start))
   --- tools/tpch-tools/bin/run-tpch-queries.sh.orig
   +++ tools/tpch-tools/bin/run-tpch-queries.sh
   @@ -183,7 +183,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        cold=$((end - start))
   @@ -193,7 +193,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot1=$((end - start))
   @@ -203,7 +203,7 @@
        mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out 2>"${RESULT_DIR}"/result"${i}".log
        if [[ $? -ne 0 ]]; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log"
   -        continue 
   +        continue
        fi
        end=$(date +%s%3N)
        hot2=$((end - start))
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437507426

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11517053429") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: $@"
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: $@"
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 156:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 161:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/load-tpcds-data.sh line 225:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 125:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 162:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 197:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 207:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 217:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/load-tpch-data.sh line 313:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 184:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 194:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 204:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
     https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2476952543

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11841887840") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   'shellcheck ' found no issues.
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -136,7 +136,7 @@
        fi
        if ! grep_output=$(grep " Value: " <<<"${output}" 2>&1); then
            grep_status=$?
   -        # shellcheck disable=SC2292       
   +        # shellcheck disable=SC2292
            if [ "${grep_status}" -eq 2 ]; then
                printf "%s\n" "${grep_output}" >&2
                printf "Error: grep command failed with status %d while processing SQL output for variable '%s'.\n" "${grep_status}" "${k}" >&2
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "cat-with-cat (via GitHub)" <gi...@apache.org>.
cat-with-cat commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435412880

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2447332675

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11595211828") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 150:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
           echo "Error: Failed to execute the SQL command: $@" >&2
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 130:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 143:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 156:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
           echo "Error: Failed to execute the SQL command: $@" >&2
                                                           ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 106:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 157:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 163:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 184:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 194:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 204:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
     https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -193,8 +193,8 @@
        echo -ne "query${i}\t" | tee -a result.csv
        start=$(date +%s%3N)
        if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
   -         <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   -         >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
   +        <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   +        >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
            echo "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log" >&2
            continue
        fi
   @@ -204,8 +204,8 @@
    
        start=$(date +%s%3N)
        if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
   -         <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   -         >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
   +        <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   +        >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
            echo "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log" >&2
            continue
        fi
   @@ -215,8 +215,8 @@
    
        start=$(date +%s%3N)
        if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
   -         <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   -         >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
   +        <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   +        >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
            echo "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log" >&2
            continue
        fi
   --- tools/tpch-tools/bin/create-tpch-tables.sh.orig
   +++ tools/tpch-tools/bin/create-tpch-tables.sh
   @@ -104,7 +104,7 @@
    echo "SF: ${SCALE_FACTOR}"
    
    if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" \
   -     -e "CREATE DATABASE IF NOT EXISTS ${DB}" 2>&1; then
   +    -e "CREATE DATABASE IF NOT EXISTS ${DB}" 2>&1; then
        echo "Error: Failed to create database '${DB}'." >&2
        exit 1
    fi
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2453992396

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11659900500") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In build.sh line 297:
       local submodule_path=$1
       ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 298:
       local submodule_name=$2
       ^---------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 299:
       local archive_url=$3
       ^------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 301:
       set +e
       ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 302:
       cd "${DORIS_HOME}"
       ^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 303:
       echo "Update ${submodule_name} submodule ..."
       ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 304:
       git submodule update --init --recursive "${submodule_path}"
       ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 305:
       exit_code=$?
       ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 306:
       if [[ "${exit_code}" -eq 0 ]]; then
       ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
          ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 307:
           cd "${submodule_path}"
           ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 308:
           submodule_commit_id=$(git rev-parse HEAD)
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                 ^----------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 309:
           cd -
           ^--^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 310:
           expect_submodule_commit_id=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                        ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 311:
           echo "Current commit ID of ${submodule_name} submodule: ${submodule_commit_id}, expected is ${expect_submodule_commit_id}"
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 313:
       set -e
       ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 314:
       if [[ "${exit_code}" -ne 0 ]]; then
       ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
          ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 315:
           set +e
           ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 317:
           submodule_commit=$(git ls-tree HEAD "${submodule_path}" | awk '{print $3}')
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                              ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 318:
           exit_code=$?
           ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 319:
           if [[ "${exit_code}" = "0" ]]; then
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
              ^------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 320:
               commit_specific_url=$(echo "${archive_url}" | sed "s/refs\/heads/${submodule_commit}/")
               ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                     ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 322:
               commit_specific_url="${archive_url}"
               ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 324:
           set -e
           ^----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 325:
           echo "Update ${submodule_name} submodule failed, start to download and extract ${commit_specific_url}"
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 327:
           mkdir -p "${DORIS_HOME}/${submodule_path}"
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In build.sh line 328:
           curl -L "${commit_specific_url}" | tar -xz -C "${DORIS_HOME}/${submodule_path}" --strip-components=1
           ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 111:
   if [ "${SCALE_FACTOR}" -eq 1 ]; then
      ^-------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ "${SCALE_FACTOR}" -eq 1 ]]; then
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 123:
   elif [ "${SCALE_FACTOR}" -eq 100 ]; then
        ^---------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 100 ]]; then
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 135:
   elif [ "${SCALE_FACTOR}" -eq 1000 ]; then
        ^----------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 1000 ]]; then
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 148:
       printf "${SCALE_FACTOR} scale is NOT supported currently\n"
              ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
           printf "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
           printf "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
           printf "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 106:
       printf "Error: Failed to drop the database ${DB}.\n" >&2
              ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 111:
       printf "Error: Failed to create the database ${DB}.\n" >&2
              ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 115:
   if [ ${SCALE_FACTOR} -eq 1 ]; then
      ^-----------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
        ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
   if [[ "${SCALE_FACTOR}" -eq 1 ]]; then
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 121:
   elif [ ${SCALE_FACTOR} -eq 100 ]; then
        ^-------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
          ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 100 ]]; then
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
   elif [ ${SCALE_FACTOR} -eq 1000 ]; then
        ^--------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
          ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 1000 ]]; then
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 133:
   elif [ ${SCALE_FACTOR} -eq 10000 ]; then
        ^---------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
          ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 10000 ]]; then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 133:
           printf "%s\n" "$output" >&2
                          ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "%s\n" "${output}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 134:
           printf "Error: Failed to execute SQL command: 'show variables like %s\\G'\n" "$k" >&2
                                                                                         ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: Failed to execute SQL command: 'show variables like %s\\G'\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 138:
       if ! grep_output=$(grep " Value: " <<< "$output" 2>&1); then
                                               ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ! grep_output=$(grep " Value: " <<< "${output}" 2>&1); then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 139:
           printf "%s\n" "$grep_output" >&2
                          ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "%s\n" "${grep_output}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 140:
           printf "Error: An error occurred while running 'grep' for variable '%s'.\n" "$k" >&2
                                                                                        ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: An error occurred while running 'grep' for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 144:
       if ! v=$(awk '{print $2}' <<< "$grep_output" 2>&1); then
                                      ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ! v=$(awk '{print $2}' <<< "${grep_output}" 2>&1); then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 145:
           printf "%s\n" "$v" >&2
                          ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "%s\n" "${v}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 150:
       if [[ -z $v ]]; then
                ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if [[ -z ${v} ]]; then
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 151:
           printf "Warning: No 'Value:' found for variable '%s'.\n" "$k" >&2
                                                                     ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Warning: No 'Value:' found for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 154:
       echo "$v"
             ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "${v}"
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 207:
           printf "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 218:
           printf "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 229:
           printf "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 112:
   if [ "${SCALE_FACTOR}" -eq 1 ]; then
      ^-------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   if [[ "${SCALE_FACTOR}" -eq 1 ]]; then
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 119:
   elif [ "${SCALE_FACTOR}" -eq 100 ]; then
        ^---------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 100 ]]; then
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 126:
   elif [ "${SCALE_FACTOR}" -eq 1000 ]; then
        ^----------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 1000 ]]; then
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 133:
   elif [ "${SCALE_FACTOR}" -eq 10000 ]; then
        ^-----------------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
   
   Did you mean: 
   elif [[ "${SCALE_FACTOR}" -eq 10000 ]]; then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 130:
           printf "%s\n" "$output" >&2
                          ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "%s\n" "${output}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 131:
           printf "Error: Failed to execute SQL command: show variables like '%s'\G\n" "$k" >&2
                                                                                        ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Error: Failed to execute SQL command: show variables like '%s'\G\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 135:
       if ! grep_output=$(grep " Value: " <<< "$output" 2>&1); then
                                               ^-----^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ! grep_output=$(grep " Value: " <<< "${output}" 2>&1); then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 136:
           printf "%s\n" "$grep_output" >&2
                          ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "%s\n" "${grep_output}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 141:
       if ! v=$(awk '{print $2}' <<< "$grep_output" 2>&1); then
                                      ^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if ! v=$(awk '{print $2}' <<< "${grep_output}" 2>&1); then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 142:
           printf "%s\n" "$v" >&2
                          ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "%s\n" "${v}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 147:
       if [[ -z $v ]]; then
                ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       if [[ -z ${v} ]]; then
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 148:
           printf "Warning: No 'Value: ' found for variable '%s'.\n" "$k" >&2
                                                                      ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
           printf "Warning: No 'Value: ' found for variable '%s'.\n" "${k}" >&2
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 152:
       echo "$v"
             ^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
   
   Did you mean: 
       echo "${v}"
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 194:
           printf "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 203:
           printf "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 212:
           printf "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
                  ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
   
   For more information:
     https://www.shellcheck.net/wiki/SC2059 -- Don't use variables in the printf...
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
     https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   
   'shfmt ' returned error 1 finding the following formatting issues:
   
   ----------
   --- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
   +++ tools/tpcds-tools/bin/run-tpcds-queries.sh
   @@ -135,13 +135,13 @@
            exit 1
        fi
    
   -    if ! grep_output=$(grep " Value: " <<< "$output" 2>&1); then
   +    if ! grep_output=$(grep " Value: " <<<"$output" 2>&1); then
            printf "%s\n" "$grep_output" >&2
            printf "Error: An error occurred while running 'grep' for variable '%s'.\n" "$k" >&2
            exit 1
        fi
    
   -    if ! v=$(awk '{print $2}' <<< "$grep_output" 2>&1); then
   +    if ! v=$(awk '{print $2}' <<<"$grep_output" 2>&1); then
            printf "%s\n" "$v" >&2
            printf "Error: awk command failed while processing the grep output.\n" >&2
            exit 1
   @@ -202,8 +202,8 @@
        echo -ne "query${i}\t" | tee -a result.csv
        start=$(date +%s%3N)
        if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
   -         <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   -         >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
   +        <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   +        >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
            printf "Error: Failed to execute query q${i} (cold run). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
            continue
        fi
   @@ -213,8 +213,8 @@
    
        start=$(date +%s%3N)
        if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
   -         <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   -         >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
   +        <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   +        >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
            printf "Error: Failed to execute query q${i} (hot run 1). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
            continue
        fi
   @@ -224,8 +224,8 @@
    
        start=$(date +%s%3N)
        if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}" --comments \
   -         <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   -         >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
   +        <"${TPCDS_QUERIES_DIR}/query${i}.sql" \
   +        >"${RESULT_DIR}/result${i}.out" 2>"${RESULT_DIR}/result${i}.log"; then
            printf "Error: Failed to execute query q${i} (hot run 2). Check the log: ${RESULT_DIR}/result${i}.log\n" >&2
            continue
        fi
   --- tools/tpch-tools/bin/create-tpch-tables.sh.orig
   +++ tools/tpch-tools/bin/create-tpch-tables.sh
   @@ -104,7 +104,7 @@
    echo "SF: ${SCALE_FACTOR}"
    
    if ! mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" \
   -     -e "CREATE DATABASE IF NOT EXISTS ${DB}" 2>&1; then
   +    -e "CREATE DATABASE IF NOT EXISTS ${DB}" 2>&1; then
        printf "Error: Failed to create database '%s'.\n" "${DB}" >&2
        exit 1
    fi
   --- tools/tpch-tools/bin/run-tpch-queries.sh.orig
   +++ tools/tpch-tools/bin/run-tpch-queries.sh
   @@ -132,13 +132,13 @@
            exit 1
        fi
    
   -    if ! grep_output=$(grep " Value: " <<< "$output" 2>&1); then
   +    if ! grep_output=$(grep " Value: " <<<"$output" 2>&1); then
            printf "%s\n" "$grep_output" >&2
            printf "Error: grep command failed while processing SQL output.\n" >&2
            exit 1
        fi
    
   -    if ! v=$(awk '{print $2}' <<< "$grep_output" 2>&1); then
   +    if ! v=$(awk '{print $2}' <<<"$grep_output" 2>&1); then
            printf "%s\n" "$v" >&2
            printf "Error: awk command failed while processing the grep output.\n" >&2
            exit 1
   ----------
   
   You can reformat the above files to meet shfmt's requirements by typing:
   
     shfmt  -w filename
   
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2435519710

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41199 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c5cd0a2f20559cbf3fcd531ad1c397fc428a2f3a, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17595	7418	7310	7310
   q2	2020	275	272	272
   q3	12111	1072	1132	1072
   q4	10579	843	801	801
   q5	7759	3070	2951	2951
   q6	237	148	145	145
   q7	1004	617	615	615
   q8	9342	1950	1948	1948
   q9	6585	6465	6387	6387
   q10	7077	2405	2452	2405
   q11	448	239	245	239
   q12	405	206	217	206
   q13	17767	3021	3036	3021
   q14	254	206	217	206
   q15	563	509	513	509
   q16	634	593	582	582
   q17	964	561	512	512
   q18	7231	6759	6679	6679
   q19	1342	1054	1028	1028
   q20	486	185	185	185
   q21	4200	3128	3190	3128
   q22	1064	1006	998	998
   Total cold run time: 109667 ms
   Total hot run time: 41199 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7248	7235	7265	7235
   q2	331	241	233	233
   q3	3022	2926	2938	2926
   q4	2078	1850	1861	1850
   q5	5737	5795	5771	5771
   q6	232	153	152	152
   q7	2185	1847	1782	1782
   q8	3355	3564	3448	3448
   q9	8885	8832	8845	8832
   q10	3593	3547	3568	3547
   q11	599	482	492	482
   q12	846	650	597	597
   q13	9590	3215	3160	3160
   q14	303	265	273	265
   q15	583	524	519	519
   q16	700	645	632	632
   q17	1843	1615	1602	1602
   q18	8313	7926	7708	7708
   q19	1702	1606	1494	1494
   q20	2121	1862	1845	1845
   q21	5688	5412	5438	5412
   q22	1117	1048	1089	1048
   Total cold run time: 70071 ms
   Total hot run time: 60540 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2437446833

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11516581952") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 143:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 149:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: '$@'"
                                                            ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-flat-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 99:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 100:
           echo "Error: Failed to execute the SQL command: '$@'"
                                                            ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 128:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 138:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/ssb-tools/bin/run-ssb-queries.sh line 148:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 112:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 120:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 127:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 134:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 141:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 151:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 156:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 161:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/load-tpcds-data.sh line 225:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 125:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 162:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 197:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 207:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpcds-tools/bin/run-tpcds-queries.sh line 217:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 107:
   if [[ $? -ne 0 ]]; then
         ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 115:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 129:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 136:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/load-tpch-data.sh line 313:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 122:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 184:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 194:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   
   In tools/tpch-tools/bin/run-tpch-queries.sh line 204:
       if [[ $? -ne 0 ]]; then
             ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ...
     https://www.shellcheck.net/wiki/SC2181 -- Check exit code directly with e.g...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2488237068

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [improvement](log)Support exception report in our benchmark utils (#40834) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42445:
URL: https://github.com/apache/doris/pull/42445#issuecomment-2466815009

   #### `sh-checker report`
   
   To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/11767066067") output.
   
   <details>
   <summary>shellcheck errors</summary>
   
   ```
   
   'shellcheck ' returned error 1 finding the following syntactical issues:
   
   ----------
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 111:
   if [ "${SCALE_FACTOR}" -eq 1 ]; then
   ^-- SC1009 (info): The mentioned syntax error was in this if expression.
                                   ^-- SC1073 (error): Couldn't parse this then clause. Fix to allow more checks.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 123:
   # shellcheck disable=SC2292
   ^-- SC1123 (error): ShellCheck directives are only valid in front of complete compound commands, like 'if', not e.g. individual 'elif' branches.
   
   
   In tools/ssb-tools/bin/create-ssb-tables.sh line 124:
   elif [ "${SCALE_FACTOR}" -eq 100 ]; then
        ^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned problems and try again.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 115:
   if [ "${SCALE_FACTOR}" -eq 1 ]; then
   ^-- SC1009 (info): The mentioned syntax error was in this if expression.
                                   ^-- SC1073 (error): Couldn't parse this then clause. Fix to allow more checks.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 121:
   # shellcheck disable=SC2292
   ^-- SC1123 (error): ShellCheck directives are only valid in front of complete compound commands, like 'if', not e.g. individual 'elif' branches.
   
   
   In tools/tpcds-tools/bin/create-tpcds-tables.sh line 122:
   elif [ "${SCALE_FACTOR}" -eq 100 ]; then
        ^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned problems and try again.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 112:
   if [ "${SCALE_FACTOR}" -eq 1 ]; then
   ^-- SC1009 (info): The mentioned syntax error was in this if expression.
                                   ^-- SC1073 (error): Couldn't parse this then clause. Fix to allow more checks.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 119:
   # shellcheck disable=SC2292
   ^-- SC1123 (error): ShellCheck directives are only valid in front of complete compound commands, like 'if', not e.g. individual 'elif' branches.
   
   
   In tools/tpch-tools/bin/create-tpch-tables.sh line 120:
   elif [ "${SCALE_FACTOR}" -eq 100 ]; then
        ^-- SC1072 (error): Unexpected keyword/token. Fix any mentioned problems and try again.
   
   For more information:
     https://www.shellcheck.net/wiki/SC1123 -- ShellCheck directives are only va...
     https://www.shellcheck.net/wiki/SC1072 -- Unexpected keyword/token. Fix any...
     https://www.shellcheck.net/wiki/SC1073 -- Couldn't parse this then clause. ...
   ----------
   
   You can address the above issues in one of three ways:
   1. Manually correct the issue in the offending shell script;
   2. Disable specific issues by adding the comment:
     # shellcheck disable=NNNN
   above the line that contains the issue, where NNNN is the error code;
   3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
   
   
   
   ```
   </details>
   
   <details>
   <summary>shfmt errors</summary>
   
   ```
   'shfmt ' found no issues.
   
   ```
   </details>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org