You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by wuzhouhui <wu...@mails.ucas.ac.cn> on 2019/02/17 13:14:43 UTC
[PATCH] Define err_abort only if SVN_DEBUG is defined
[[[
Define err_abort only if SVN_DEBUG is defined.
* subversion/libsvn_subr/error.c
(err_abort): Define this function only if SVN_DEBUG is defined, so
an unused function warning is fixed.
]]]
Index: subversion/libsvn_subr/error.c
===================================================================
--- subversion/libsvn_subr/error.c (revision 1853741)
+++ subversion/libsvn_subr/error.c (working copy)
@@ -146,6 +146,7 @@ svn_error__locate(const char *file, long line)
/* Cleanup function for errors. svn_error_clear () removes this so
errors that are properly handled *don't* hit this code. */
+#ifdef SVN_DEBUG
static apr_status_t err_abort(void *data)
{
svn_error_t *err = data; /* For easy viewing in a debugger */
@@ -155,6 +156,7 @@ static apr_status_t err_abort(void *data)
abort();
return APR_SUCCESS;
}
+#endif
static svn_error_t *
Re: [PATCH] Define err_abort only if SVN_DEBUG is defined
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
wuzhouhui wrote on Sun, 17 Feb 2019 23:38 +00:00:
>
> > On Feb 17, 2019, at 11:36 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> >
> > wuzhouhui wrote on Sun, 17 Feb 2019 13:15 +00:00:
> >> Define err_abort only if SVN_DEBUG is defined.
> >>
> >> * subversion/libsvn_subr/error.c
> >> (err_abort): Define this function only if SVN_DEBUG is defined, so
> >> an unused function warning is fixed.
> >
> > Thanks! Applied in r1853761 with tweaks to the log message. Would you
> > like for this to be nominated for backport as well?
>
> Yes, I would like this to be nominated for tackport.
Done.
Re: [PATCH] Define err_abort only if SVN_DEBUG is defined
Posted by wuzhouhui <wu...@mails.ucas.ac.cn>.
> On Feb 17, 2019, at 11:36 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
>
> wuzhouhui wrote on Sun, 17 Feb 2019 13:15 +00:00:
>> Define err_abort only if SVN_DEBUG is defined.
>>
>> * subversion/libsvn_subr/error.c
>> (err_abort): Define this function only if SVN_DEBUG is defined, so
>> an unused function warning is fixed.
>
> Thanks! Applied in r1853761 with tweaks to the log message. Would you
> like for this to be nominated for backport as well?
Yes, I would like this to be nominated for tackport.
Re: [PATCH] Define err_abort only if SVN_DEBUG is defined
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
wuzhouhui wrote on Sun, 17 Feb 2019 13:15 +00:00:
> Define err_abort only if SVN_DEBUG is defined.
>
> * subversion/libsvn_subr/error.c
> (err_abort): Define this function only if SVN_DEBUG is defined, so
> an unused function warning is fixed.
Thanks! Applied in r1853761 with tweaks to the log message. Would you
like for this to be nominated for backport as well?