You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Brian Denny <br...@briandenny.net> on 2002/10/17 02:20:21 UTC
[PATCH] test import of executable separately from basic import
the only issue i can think of with this patch is:
- maybe "basic_import_executable" shouldn't be in "basic_tests.py"?
should it go in commit_tests.py instead?
in spite of my problems running the tests on windows, the particular
tests that this patch touches run correctly for me both before and after
applying the patch.
patch attached, log follows.
-brian
Log:
Split test "basic_import" into two tests: "basic_import", which
is run on all platforms, and "basic_import_executable", which
is SKIPped on non-posix platforms.
* subversion/tests/clients/cmdline/basic_tests.py
- added test 'basic_import_executable'
- pared down 'basic_import' to simpler, platform-neutral functionality
Re: [PATCH] test import of executable separately from basic import
Posted by Branko Čibej <br...@xbc.nu>.
Brian Denny wrote:
>>>it may need to be changed to account for rev 3396.
>>>
>>>
>>>
>>What was that change already? The underscore-in-status thing?
>>
>>
>
>yes. should be a pretty easy/obvious adjustment to the patch.
>
>i'll have a chance to resubmit the patch sometime in the next day
>or so; of course i won't mind if you want to just tweak it yourself
>and commit.
>
>
In case you missed it, this is committed in r3449.
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] test import of executable separately from basic import
Posted by Brian Denny <br...@briandenny.net>.
> >it may need to be changed to account for rev 3396.
> >
> What was that change already? The underscore-in-status thing?
yes. should be a pretty easy/obvious adjustment to the patch.
i'll have a chance to resubmit the patch sometime in the next day
or so; of course i won't mind if you want to just tweak it yourself
and commit.
-brian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] test import of executable separately from basic import
Posted by Branko Čibej <br...@xbc.nu>.
Brian Denny wrote:
>>>yeah, we do. new patch attached, log (unchanged) follows.
>>>
>>>
>>>
>>Ah, wonderful. This patch is on my kill^H^H^H^Hcommit list now. Thanks!
>>
>>
>>
>
>hm, you haven't gotten to commiting this yet, have you...
>
Yes, so sorry... it's sitting in my inbox, highlighted in bright red :-)
I'll try to get it in today
>it may need to be changed to account for rev 3396.
>
What was that change already? The underscore-in-status thing?
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] test import of executable separately from basic import
Posted by Brian Denny <br...@briandenny.net>.
> >
> >yeah, we do. new patch attached, log (unchanged) follows.
> >
>
> Ah, wonderful. This patch is on my kill^H^H^H^Hcommit list now. Thanks!
>
hm, you haven't gotten to commiting this yet, have you...
it may need to be changed to account for rev 3396.
-brian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] test import of executable separately from basic import
Posted by Branko Čibej <br...@xbc.nu>.
Brian Denny wrote:
>On Thu, 17 Oct 2002, [UTF-8] Branko ÄŒibej wrote:
>
>
>
>>Incidentally, what happens if you run the tests on the Release build
>>(python win-tests.py r)?
>>
>>
>
>haven't had time to look at it yet. in a day or two...
>
>
>
>>BTW, the patch seems fine, except for one thing: I'd like to factor out
>>the open(foo)/close pairs that create a new file. I wonder if we don't
>>have a set-file-contents utility function somewhere; if we don't, we
>>should. :-)
>>
>>
>
>yeah, we do. new patch attached, log (unchanged) follows.
>
Ah, wonderful. This patch is on my kill^H^H^H^Hcommit list now. Thanks!
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] test import of executable separately from basic import
Posted by Brian Denny <br...@briandenny.net>.
On Thu, 17 Oct 2002, [UTF-8] Branko Äibej wrote:
> Incidentally, what happens if you run the tests on the Release build
> (python win-tests.py r)?
haven't had time to look at it yet. in a day or two...
> BTW, the patch seems fine, except for one thing: I'd like to factor out
> the open(foo)/close pairs that create a new file. I wonder if we don't
> have a set-file-contents utility function somewhere; if we don't, we
> should. :-)
yeah, we do. new patch attached, log (unchanged) follows.
-brian
Log:
Split test "basic_import" into two tests: "basic_import", which
is run on all platforms, and "basic_import_executable", which
is SKIPped on non-posix platforms.
* subversion/tests/clients/cmdline/basic_tests.py
- added test 'basic_import_executable'
- pared down 'basic_import' to simpler, platform-neutral functionality
Re: [PATCH] test import of executable separately from basic import
Posted by Branko Čibej <br...@xbc.nu>.
Brian Denny wrote:
>the only issue i can think of with this patch is:
>- maybe "basic_import_executable" shouldn't be in "basic_tests.py"?
> should it go in commit_tests.py instead?
>
>in spite of my problems running the tests on windows, the particular
>tests that this patch touches run correctly for me both before and after
>applying the patch.
>
Incidentally, what happens if you run the tests on the Release build
(python win-tests.py r)?
>patch attached, log follows.
>
>-brian
>
>Log:
>
>Split test "basic_import" into two tests: "basic_import", which
>is run on all platforms, and "basic_import_executable", which
>is SKIPped on non-posix platforms.
>
>* subversion/tests/clients/cmdline/basic_tests.py
> - added test 'basic_import_executable'
> - pared down 'basic_import' to simpler, platform-neutral functionality
>
BTW, the patch seems fine, except for one thing: I'd like to factor out
the open(foo)/close pairs that create a new file. I wonder if we don't
have a set-file-contents utility function somewhere; if we don't, we
should. :-)
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org