You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 02:27:32 UTC

[GitHub] [spark] AngersZhuuuu commented on a diff in pull request #36477: [SPARK-39120][SQL] Prunes the duplicate columns from child of UnaryNode

AngersZhuuuu commented on code in PR #36477:
URL: https://github.com/apache/spark/pull/36477#discussion_r867590079


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -855,6 +855,15 @@ object ColumnPruning extends Rule[LogicalPlan] {
     case e @ Expand(_, _, child) if !child.outputSet.subsetOf(e.references) =>
       e.copy(child = prunedChild(child, e.references))
 
+    // Prunes the duplicate columns from child of UnaryNode, e.g.: Aggregate
+    case p: UnaryNode
+      if p.child.isInstanceOf[Project] && p.child.output.size > p.child.outputSet.size =>

Review Comment:
   Here should exclude script transform.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org