You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/02/18 19:30:27 UTC
[jira] Created: (THRIFT-710) TBinaryProtocol should access buffers
directly when possible
TBinaryProtocol should access buffers directly when possible
------------------------------------------------------------
Key: THRIFT-710
URL: https://issues.apache.org/jira/browse/THRIFT-710
Project: Thrift
Issue Type: Improvement
Components: Library (Java)
Affects Versions: 0.3
Reporter: Bryan Duxbury
Fix For: 0.3
TBinaryProtocol can probably take even more advantage of direct buffer access than TCompactProtocol. Identify the relevant spots and clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-710) TBinaryProtocol should access buffers
directly when possible
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-710.
--------------------------------
Resolution: Fixed
I just committed this.
> TBinaryProtocol should access buffers directly when possible
> ------------------------------------------------------------
>
> Key: THRIFT-710
> URL: https://issues.apache.org/jira/browse/THRIFT-710
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Java)
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-710.patch
>
>
> TBinaryProtocol can probably take even more advantage of direct buffer access than TCompactProtocol. Identify the relevant spots and clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-710) TBinaryProtocol should access buffers
directly when possible
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-710:
---------------------------------
Attachment: thrift-710.patch
This patch makes TBinaryProtocol use direct buffer access in the relevant methods. My performance testing was somewhat rudimentary, but I think it may have as much as doubled performance. Obviously your performance boost will be really dependent on the contents of your struct, but this seems pretty great.
As a side effect of this issue, I refactored the TCompactProtocol test so that we could exact TBinaryProtocol to the same bevy of test cases.
> TBinaryProtocol should access buffers directly when possible
> ------------------------------------------------------------
>
> Key: THRIFT-710
> URL: https://issues.apache.org/jira/browse/THRIFT-710
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Java)
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-710.patch
>
>
> TBinaryProtocol can probably take even more advantage of direct buffer access than TCompactProtocol. Identify the relevant spots and clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-710) TBinaryProtocol should access buffers
directly when possible
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-710:
------------------------------------
Assignee: Bryan Duxbury
> TBinaryProtocol should access buffers directly when possible
> ------------------------------------------------------------
>
> Key: THRIFT-710
> URL: https://issues.apache.org/jira/browse/THRIFT-710
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Java)
> Affects Versions: 0.3
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
> Attachments: thrift-710.patch
>
>
> TBinaryProtocol can probably take even more advantage of direct buffer access than TCompactProtocol. Identify the relevant spots and clean it up.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.