You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by al...@apache.org on 2013/12/19 14:57:26 UTC

[1/2] git commit: Don't drop local mutations without a trace

Updated Branches:
  refs/heads/cassandra-2.0 4a6f8a661 -> d9dac014e


Don't drop local mutations without a trace

patch by Aleksey Yeschenko; reviewed by Jonathan Ellis for
CASSANDRA-6510


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/38642c5b
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/38642c5b
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/38642c5b

Branch: refs/heads/cassandra-2.0
Commit: 38642c5b2c5e410da29f54b0918d7358c1592402
Parents: b73178d
Author: Aleksey Yeschenko <al...@apache.org>
Authored: Thu Dec 19 16:48:10 2013 +0300
Committer: Aleksey Yeschenko <al...@apache.org>
Committed: Thu Dec 19 16:48:10 2013 +0300

----------------------------------------------------------------------
 CHANGES.txt                                                  | 2 ++
 src/java/org/apache/cassandra/config/DatabaseDescriptor.java | 1 +
 src/java/org/apache/cassandra/service/StorageProxy.java      | 7 +++----
 3 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/38642c5b/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index a1514d0..3488cde 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,8 @@
 1.2.14
  * Allow executing CREATE statements multiple times (CASSANDRA-6471)
  * Don't send confusing info with timeouts (CASSANDRA-6491)
+ * Don't resubmit counter mutation runnables internally (CASSANDRA-6427)
+ * Don't drop local mutations without a trace (CASSANDRA-6510)
 
 1.2.13
  * Improved error message on bad properties in DDL queries (CASSANDRA-6453)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/38642c5b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
index 2d29dde..7843fc1 100644
--- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
+++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
@@ -862,6 +862,7 @@ public class DatabaseDescriptor
                 return getTruncateRpcTimeout();
             case READ_REPAIR:
             case MUTATION:
+            case COUNTER_MUTATION:
                 return getWriteRpcTimeout();
             default:
                 return getRpcTimeout();

http://git-wip-us.apache.org/repos/asf/cassandra/blob/38642c5b/src/java/org/apache/cassandra/service/StorageProxy.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/org/apache/cassandra/service/StorageProxy.java
index e6cd755..dbe029b 100644
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -646,15 +646,14 @@ public class StorageProxy implements StorageProxyMBean
 
     private static void insertLocal(final RowMutation rm, final AbstractWriteResponseHandler responseHandler)
     {
-        Runnable runnable = new DroppableRunnable(MessagingService.Verb.MUTATION)
+        StageManager.getStage(Stage.MUTATION).execute(new LocalMutationRunnable()
         {
             public void runMayThrow() throws IOException
             {
                 rm.apply();
                 responseHandler.response(null);
             }
-        };
-        StageManager.getStage(Stage.MUTATION).execute(runnable);
+        });
     }
 
     /**
@@ -758,7 +757,7 @@ public class StorageProxy implements StorageProxyMBean
                                              final String localDataCenter,
                                              final ConsistencyLevel consistency_level)
     {
-        return new LocalMutationRunnable()
+        return new DroppableRunnable(MessagingService.Verb.COUNTER_MUTATION)
         {
             public void runMayThrow() throws IOException
             {


[2/2] git commit: Merge branch 'cassandra-1.2' into cassandra-2.0

Posted by al...@apache.org.
Merge branch 'cassandra-1.2' into cassandra-2.0

Conflicts:
	CHANGES.txt


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/d9dac014
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/d9dac014
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/d9dac014

Branch: refs/heads/cassandra-2.0
Commit: d9dac014ecea13bf52071c2d27d974c811d02a9f
Parents: 4a6f8a6 38642c5
Author: Aleksey Yeschenko <al...@apache.org>
Authored: Thu Dec 19 16:57:14 2013 +0300
Committer: Aleksey Yeschenko <al...@apache.org>
Committed: Thu Dec 19 16:57:14 2013 +0300

----------------------------------------------------------------------
 CHANGES.txt                                     |  3 +-
 .../cassandra/config/DatabaseDescriptor.java    |  1 +
 .../apache/cassandra/service/StorageProxy.java  | 42 ++++++++++++++++++--
 3 files changed, 42 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/d9dac014/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index d6223be,3488cde..622a1a9
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,20 -1,10 +1,19 @@@
 -1.2.14
 - * Allow executing CREATE statements multiple times (CASSANDRA-6471)
 - * Don't send confusing info with timeouts (CASSANDRA-6491)
 - * Don't resubmit counter mutation runnables internally (CASSANDRA-6427)
 - * Don't drop local mutations without a trace (CASSANDRA-6510)
 -
 -1.2.13
 +2.0.4
 + * add client encryption support to sstableloader (CASSANDRA-6378)
 + * Fix accept() loop for SSL sockets post-shutdown (CASSANDRA-6468)
 + * Fix size-tiered compaction in LCS L0 (CASSANDRA-6496)
 + * Fix assertion failure in filterColdSSTables (CASSANDRA-6483)
 + * Fix row tombstones in larger-than-memory compactions (CASSANDRA-6008)
 + * Fix cleanup ClassCastException (CASSANDRA-6462)
 + * Reduce gossip memory use by interning VersionedValue strings (CASSANDRA-6410)
 + * Allow specifying datacenters to participate in a repair (CASSANDRA-6218)
 + * Fix divide-by-zero in PCI (CASSANDRA-6403)
 + * Fix setting last compacted key in the wrong level for LCS (CASSANDRA-6284)
 + * Add millisecond precision formats to the timestamp parser (CASSANDRA-6395)
 + * Expose a total memtable size metric for a CF (CASSANDRA-6391)
 + * cqlsh: handle symlinks properly (CASSANDRA-6425)
-  * Don't resubmit counter mutation runnables internally (CASSANDRA-6427)
 + * Fix potential infinite loop when paging query with IN (CASSANDRA-6464)
 +Merged from 1.2:
   * Improved error message on bad properties in DDL queries (CASSANDRA-6453)
   * Randomize batchlog candidates selection (CASSANDRA-6481)
   * Fix thundering herd on endpoint cache invalidation (CASSANDRA-6345, 6485)
@@@ -31,47 -25,9 +30,49 @@@
     (CASSANDRA-6413)
   * (Hadoop) add describe_local_ring (CASSANDRA-6268)
   * Fix handling of concurrent directory creation failure (CASSANDRA-6459)
 + * Allow executing CREATE statements multiple times (CASSANDRA-6471)
 + * Don't send confusing info with timeouts (CASSANDRA-6491)
++ * Don't resubmit counter mutation runnables internally (CASSANDRA-6427)
++ * Don't drop local mutations without a trace (CASSANDRA-6510)
  
  
 -1.2.12
 +2.0.3
 + * Fix FD leak on slice read path (CASSANDRA-6275)
 + * Cancel read meter task when closing SSTR (CASSANDRA-6358)
 + * free off-heap IndexSummary during bulk (CASSANDRA-6359)
 + * Recover from IOException in accept() thread (CASSANDRA-6349)
 + * Improve Gossip tolerance of abnormally slow tasks (CASSANDRA-6338)
 + * Fix trying to hint timed out counter writes (CASSANDRA-6322)
 + * Allow restoring specific columnfamilies from archived CL (CASSANDRA-4809)
 + * Avoid flushing compaction_history after each operation (CASSANDRA-6287)
 + * Fix repair assertion error when tombstones expire (CASSANDRA-6277)
 + * Skip loading corrupt key cache (CASSANDRA-6260)
 + * Fixes for compacting larger-than-memory rows (CASSANDRA-6274)
 + * Compact hottest sstables first and optionally omit coldest from
 +   compaction entirely (CASSANDRA-6109)
 + * Fix modifying column_metadata from thrift (CASSANDRA-6182)
 + * cqlsh: fix LIST USERS output (CASSANDRA-6242)
 + * Add IRequestSink interface (CASSANDRA-6248)
 + * Update memtable size while flushing (CASSANDRA-6249)
 + * Provide hooks around CQL2/CQL3 statement execution (CASSANDRA-6252)
 + * Require Permission.SELECT for CAS updates (CASSANDRA-6247)
 + * New CQL-aware SSTableWriter (CASSANDRA-5894)
 + * Reject CAS operation when the protocol v1 is used (CASSANDRA-6270)
 + * Correctly throw error when frame too large (CASSANDRA-5981)
 + * Fix serialization bug in PagedRange with 2ndary indexes (CASSANDRA-6299)
 + * Fix CQL3 table validation in Thrift (CASSANDRA-6140)
 + * Fix bug missing results with IN clauses (CASSANDRA-6327)
 + * Fix paging with reversed slices (CASSANDRA-6343)
 + * Set minTimestamp correctly to be able to drop expired sstables (CASSANDRA-6337)
 + * Support NaN and Infinity as float literals (CASSANDRA-6003)
 + * Remove RF from nodetool ring output (CASSANDRA-6289)
 + * Fix attempting to flush empty rows (CASSANDRA-6374)
 + * Fix potential out of bounds exception when paging (CASSANDRA-6333)
 +Merged from 1.2:
 + * Optimize FD phi calculation (CASSANDRA-6386)
 + * Improve initial FD phi estimate when starting up (CASSANDRA-6385)
 + * Don't list CQL3 table in CLI describe even if named explicitely 
 +   (CASSANDRA-5750)
   * Invalidate row cache when dropping CF (CASSANDRA-6351)
   * add non-jamm path for cached statements (CASSANDRA-6293)
   * (Hadoop) Require CFRR batchSize to be at least 2 (CASSANDRA-6114)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/d9dac014/src/java/org/apache/cassandra/config/DatabaseDescriptor.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/cassandra/blob/d9dac014/src/java/org/apache/cassandra/service/StorageProxy.java
----------------------------------------------------------------------
diff --cc src/java/org/apache/cassandra/service/StorageProxy.java
index 2da9d38,dbe029b..be91d0d
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@@ -985,19 -646,14 +985,18 @@@ public class StorageProxy implements St
  
      private static void insertLocal(final RowMutation rm, final AbstractWriteResponseHandler responseHandler)
      {
-         Runnable runnable = new DroppableRunnable(MessagingService.Verb.MUTATION)
+         StageManager.getStage(Stage.MUTATION).execute(new LocalMutationRunnable()
          {
 -            public void runMayThrow() throws IOException
 +            public void runMayThrow()
              {
 -                rm.apply();
 -                responseHandler.response(null);
 +                IMutation processed = SinkManager.processWriteRequest(rm);
 +                if (processed != null)
 +                {
 +                    processed.apply();
 +                    responseHandler.response(null);
 +                }
              }
-         };
-         StageManager.getStage(Stage.MUTATION).execute(runnable);
+         });
      }
  
      /**