You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ji...@apache.org on 2004/04/22 02:42:56 UTC
[jira] Created: (JAMES-268) Spooler.accept(...) can leave locked messages and leak memory
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JAMES-268
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JAMES-268
Summary: Spooler.accept(...) can leave locked messages and leak memory
Type: Bug
Status: Unassigned
Priority: Major
Project: James
Components:
MailStore & MailRepository
Fix Fors:
2.2.0RC1
Versions:
2.2.0RC1
Assignee:
Reporter: Noel J. Bergman
Created: Wed, 21 Apr 2004 5:42 PM
Updated: Wed, 21 Apr 2004 5:42 PM
Description:
I believe there is a memory leak under an error condition in the spooler that I'll be fixing, but that should be able to wait for a 2.2.1. If I am correct, the nature of the error is here:
if (lock(s)) {
MailImpl mail = null;
try {
mail = retrieve(s);
} catch (javax.mail.MessagingException e) {
...
}
if (mail == null) {
continue;
}
If retrieve returns null or throws an exception, the lock is kept, and we leak memory. Also ...
if (filter.accept (mail.getName(),
mail.getState(),
mail.getLastUpdated().getTime(),
mail.getErrorMessage())) {
return mail;
}
If the filter doesn't accept, we leak the lock info, although we'll eventually clean it up. The problem here is that the message is forever locked for this specific thread.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-268) Spooler.accept(...) can leave locked messages and leak memory
Posted by ji...@apache.org.
The following issue has been updated:
Updater: Noel J. Bergman (mailto:noel@devtech.com)
Date: Wed, 21 Apr 2004 7:10 PM
Changes:
Fix Version changed to 2.2.0RC2
Fix Version changed from 2.2.0RC1
---------------------------------------------------------------------
For a full history of the issue, see:
http://issues.apache.org/jira/browse/JAMES-268?page=history
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JAMES-268
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JAMES-268
Summary: Spooler.accept(...) can leave locked messages and leak memory
Type: Bug
Status: Resolved
Priority: Major
Resolution: FIXED
Project: James
Components:
MailStore & MailRepository
Fix Fors:
2.2.0RC2
Versions:
2.2.0RC1
Assignee:
Reporter: Noel J. Bergman
Created: Wed, 21 Apr 2004 5:42 PM
Updated: Wed, 21 Apr 2004 7:10 PM
Description:
I believe there is a memory leak under an error condition in the spooler that I'll be fixing, but that should be able to wait for a 2.2.1. If I am correct, the nature of the error is here:
if (lock(s)) {
MailImpl mail = null;
try {
mail = retrieve(s);
} catch (javax.mail.MessagingException e) {
...
}
if (mail == null) {
continue;
}
If retrieve returns null or throws an exception, the lock is kept, and we leak memory. Also ...
if (filter.accept (mail.getName(),
mail.getState(),
mail.getLastUpdated().getTime(),
mail.getErrorMessage())) {
return mail;
}
If the filter doesn't accept, we leak the lock info, although we'll eventually clean it up. The problem here is that the message is forever locked for this specific thread.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Closed: (JAMES-268) Spooler.accept(...) can leave locked messages and leak memory
Posted by ji...@apache.org.
Message:
The following issue has been closed.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JAMES-268
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JAMES-268
Summary: Spooler.accept(...) can leave locked messages and leak memory
Type: Bug
Status: Closed
Priority: Major
Resolution: FIXED
Project: James
Components:
MailStore & MailRepository
Fix Fors:
2.2.0RC2
Versions:
2.2.0RC1
Assignee:
Reporter: Noel J. Bergman
Created: Wed, 21 Apr 2004 5:42 PM
Updated: Sat, 5 Jun 2004 12:29 PM
Description:
I believe there is a memory leak under an error condition in the spooler that I'll be fixing, but that should be able to wait for a 2.2.1. If I am correct, the nature of the error is here:
if (lock(s)) {
MailImpl mail = null;
try {
mail = retrieve(s);
} catch (javax.mail.MessagingException e) {
...
}
if (mail == null) {
continue;
}
If retrieve returns null or throws an exception, the lock is kept, and we leak memory. Also ...
if (filter.accept (mail.getName(),
mail.getState(),
mail.getLastUpdated().getTime(),
mail.getErrorMessage())) {
return mail;
}
If the filter doesn't accept, we leak the lock info, although we'll eventually clean it up. The problem here is that the message is forever locked for this specific thread.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-268) Spooler.accept(...) can leave locked messages and leak memory
Posted by ji...@apache.org.
Message:
The following issue has been resolved as FIXED.
Resolver: Noel J. Bergman
Date: Wed, 21 Apr 2004 6:50 PM
Committed fix to CVS. Initial tests appear to indicate that all is well.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/JAMES-268
Here is an overview of the issue:
---------------------------------------------------------------------
Key: JAMES-268
Summary: Spooler.accept(...) can leave locked messages and leak memory
Type: Bug
Status: Resolved
Priority: Major
Resolution: FIXED
Project: James
Components:
MailStore & MailRepository
Fix Fors:
2.2.0RC1
Versions:
2.2.0RC1
Assignee:
Reporter: Noel J. Bergman
Created: Wed, 21 Apr 2004 5:42 PM
Updated: Wed, 21 Apr 2004 6:50 PM
Description:
I believe there is a memory leak under an error condition in the spooler that I'll be fixing, but that should be able to wait for a 2.2.1. If I am correct, the nature of the error is here:
if (lock(s)) {
MailImpl mail = null;
try {
mail = retrieve(s);
} catch (javax.mail.MessagingException e) {
...
}
if (mail == null) {
continue;
}
If retrieve returns null or throws an exception, the lock is kept, and we leak memory. Also ...
if (filter.accept (mail.getName(),
mail.getState(),
mail.getLastUpdated().getTime(),
mail.getErrorMessage())) {
return mail;
}
If the filter doesn't accept, we leak the lock info, although we'll eventually clean it up. The problem here is that the message is forever locked for this specific thread.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org