You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michael Mosmann (JIRA)" <ji...@apache.org> on 2010/01/15 07:40:54 UTC
[jira] Created: (WICKET-2679) checkRendering() throws Exception if
TransparentResolver is invisible
checkRendering() throws Exception if TransparentResolver is invisible
---------------------------------------------------------------------
Key: WICKET-2679
URL: https://issues.apache.org/jira/browse/WICKET-2679
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.5, 1.4.4, 1.4.3, 1.4.2, 1.4.1
Reporter: Michael Mosmann
Attachments: de.flapdoodle.bugs--wicket-transparent-resolver.zip
When a page has a TransparentResolver which is invisible, then rendering fails, if one child has it's own markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2679) checkRendering() throws Exception
if TransparentResolver is invisible
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801344#action_12801344 ]
Juergen Donnerstag commented on WICKET-2679:
--------------------------------------------
I'm not sure yet what the root cause is, but the problem goes away when you remove SimplePanel("childMarkup") from the homepage. Which means the problem could as well be <wicket:container> or a combination of both.
> checkRendering() throws Exception if TransparentResolver is invisible
> ---------------------------------------------------------------------
>
> Key: WICKET-2679
> URL: https://issues.apache.org/jira/browse/WICKET-2679
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5
> Reporter: Michael Mosmann
> Attachments: de.flapdoodle.bugs--wicket-transparent-resolver.zip
>
>
> When a page has a TransparentResolver which is invisible, then rendering fails, if one child has it's own markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2679) checkRendering() throws Exception
if TransparentResolver is invisible
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801350#action_12801350 ]
Juergen Donnerstag commented on WICKET-2679:
--------------------------------------------
isTransparent is regulary causing users problem which is why we removed it in 1.5. Though it is still possible via TransparentWebContainer or IComponentResolver.
The underlying problem is that the transparent container doesn't know its children - it can be any child of the parent container. The transparent container potentially could know them but than again only if all its children are rendered (visible == true). Like in your case, where the transparent container (and its children) never get rendered, it is impossible (in 1.4) to determine whether childNoMarkup or childMarkup should be a child of the transparent container or whether it really is a child of the page.
For the sake of performance, we do not render invisble transparent containers, just to be able to determine its children.
Which is why checkRendering sometimes needs to guess. And that is exactly what is happening here (see Page.java 1127). Unfortunately that "guessing" fails whenever a a transparent container has a grand child.
That could be fixed, but it remains guessing.
> checkRendering() throws Exception if TransparentResolver is invisible
> ---------------------------------------------------------------------
>
> Key: WICKET-2679
> URL: https://issues.apache.org/jira/browse/WICKET-2679
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5
> Reporter: Michael Mosmann
> Attachments: de.flapdoodle.bugs--wicket-transparent-resolver.zip
>
>
> When a page has a TransparentResolver which is invisible, then rendering fails, if one child has it's own markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2679) checkRendering() throws Exception
if TransparentResolver is invisible
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801345#action_12801345 ]
Juergen Donnerstag commented on WICKET-2679:
--------------------------------------------
Sorry. You mentioned it already: ... when the childmarkup has it's own markup.
> checkRendering() throws Exception if TransparentResolver is invisible
> ---------------------------------------------------------------------
>
> Key: WICKET-2679
> URL: https://issues.apache.org/jira/browse/WICKET-2679
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5
> Reporter: Michael Mosmann
> Attachments: de.flapdoodle.bugs--wicket-transparent-resolver.zip
>
>
> When a page has a TransparentResolver which is invisible, then rendering fails, if one child has it's own markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2679) checkRendering() throws Exception if
TransparentResolver is invisible
Posted by "Michael Mosmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Mosmann updated WICKET-2679:
------------------------------------
Attachment: de.flapdoodle.bugs--wicket-transparent-resolver.zip
> checkRendering() throws Exception if TransparentResolver is invisible
> ---------------------------------------------------------------------
>
> Key: WICKET-2679
> URL: https://issues.apache.org/jira/browse/WICKET-2679
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5
> Reporter: Michael Mosmann
> Attachments: de.flapdoodle.bugs--wicket-transparent-resolver.zip
>
>
> When a page has a TransparentResolver which is invisible, then rendering fails, if one child has it's own markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2679) checkRendering() throws Exception if
TransparentResolver is invisible
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juergen Donnerstag resolved WICKET-2679.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M1
1.4.6
Assignee: Juergen Donnerstag
improved guessing (see previous comment)
> checkRendering() throws Exception if TransparentResolver is invisible
> ---------------------------------------------------------------------
>
> Key: WICKET-2679
> URL: https://issues.apache.org/jira/browse/WICKET-2679
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5
> Reporter: Michael Mosmann
> Assignee: Juergen Donnerstag
> Fix For: 1.4.6, 1.5-M1
>
> Attachments: de.flapdoodle.bugs--wicket-transparent-resolver.zip
>
>
> When a page has a TransparentResolver which is invisible, then rendering fails, if one child has it's own markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.