You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/06/09 14:28:30 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new issue, #224: Warn for unused result
paleolimbot opened a new issue, #224:
URL: https://github.com/apache/arrow-nanoarrow/issues/224
In #221 I fixed an error where I had forgotten to check `ArrowErrorCode`. David suggested:
> Seems like you could guard against forgetting with `-Wunused-result` and manually annotating functions with the (compiler specific) `__attribute__((warn_unused_result))` though that is rather a hassle
I believe there is also a macro for checking printf that's used in ADBC. That would also be useful to check calls to `ArrowErrorSet()` (some of which are difficult to actually hit in test code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Warn for unused `ArrowErrorCode` [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot closed issue #224: Warn for unused `ArrowErrorCode`
URL: https://github.com/apache/arrow-nanoarrow/issues/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #224: Warn for unused `ArrowErrorCode`
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #224:
URL: https://github.com/apache/arrow-nanoarrow/issues/224#issuecomment-1728975036
Just a note that I'm bumping this to 0.4 because it would result in a lot of compiler warnings for any project that was using a development version between 0.2 and 0.3 (and because the 0.3 release is forthcoming!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on issue #224: Warn for unused `ArrowErrorCode`
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #224:
URL: https://github.com/apache/arrow-nanoarrow/issues/224#issuecomment-1584680738
Yes, the printf macro is here: https://github.com/apache/arrow-adbc/blob/2ac9e8be3fcaffe82874e8f2e10694321fdec76a/c/driver/common/utils.h#L24C1-L28
Functions annotated with this will be treated by the compiler like printf and emit similar warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Warn for unused `ArrowErrorCode` [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #224:
URL: https://github.com/apache/arrow-nanoarrow/issues/224#issuecomment-1911331765
Closed in #351.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org