[GitHub] [kylin] nichunen commented on a change in pull request #435: when dimvalue`s len > short.max_value then [Extract Fact Table Distinct Columns] err

[GitBox <gi...@apache.org>]

nichunen commented on a change in pull request #435: when dimvalue`s len > short.max_value then [Extract Fact Table Distinct Columns] err
URL: https://github.com/apache/kylin/pull/435#discussion_r270812056
 
 

 ##########
 File path: core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionary.java
 ##########
 @@ -89,6 +89,35 @@ public TrieDictionary(byte[] trieBytes) {
         init(trieBytes);
     }
 
+    private String readConverterName(DataInputStream headIn) throws Exception{
+        try {
+            this.maxValueLength = headIn.readInt();
+            if (maxValueLength < 0) {
+                throw new IllegalStateException("maxValueLength is negative (" + maxValueLength
+                        + "). Dict value is too long, whose length is larger than " + Integer.MAX_VALUE);
+            }
+            String converterName = headIn.readUTF();
+
+            return converterName;
+        } catch (Exception e) {
 
 Review comment:
   When will this happen?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services