You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2023/05/03 21:40:53 UTC

[GitHub] [arrow] candiduslynx opened a new issue, #35421: [Go] Some types don't follow the `ValueStr` <-> `AppendValueFromStr` convention

candiduslynx opened a new issue, #35421:
URL: https://github.com/apache/arrow/issues/35421

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   It's [stated](https://github.com/apache/arrow/blob/main/go/arrow/array/builder.go#L64) in the `array.Builder` interface description that `AppendValueFromString adds a new value from a string. Inverse of array.ValueStr(i int) string`.
   
   However, some types fail to adhere to this rule.
   One example I found was `array.DayTimeInterval` (along with `array.DayTimeIntervalBuilder`):
   * [`array.DayTimeInterval.ValueStr`](https://github.com/apache/arrow/blob/main/go/arrow/array/interval.go#L345-L350) returns a quoted value from `fmt.Sprintf`
   * [`array.DayTimeIntervalBuilder.DayTimeIntervalBuilder`](https://github.com/apache/arrow/blob/main/go/arrow/array/interval.go#L560-L572) tries to parse via JSON marshaling
   
   The issue was likely introduced in #34986
   
   ### Component(s)
   
   Go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zeroshade closed issue #35421: [Go] Some types don't follow the `ValueStr` <-> `AppendValueFromStr` convention

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.

zeroshade closed issue #35421: [Go] Some types don't follow the `ValueStr` <-> `AppendValueFromStr` convention
URL: https://github.com/apache/arrow/issues/35421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] candiduslynx commented on issue #35421: [Go] Some types don't follow the `ValueStr` <-> `AppendValueFromStr` convention

Posted by "candiduslynx (via GitHub)" <gi...@apache.org>.

candiduslynx commented on issue #35421:
URL: https://github.com/apache/arrow/issues/35421#issuecomment-1533792023

   I think to properly fix this the tests for Append/ValueStr should be added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org