[GitHub] spark pull request: [SPARK-14130] [SQL] Throw exceptions for ALTER...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12714#discussion_r64093234
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -179,6 +173,11 @@ unsupportedHiveNativeCommands
         | kw1=ALTER kw2=TABLE tableIdentifier kw3=TOUCH
         | kw1=ALTER kw2=TABLE tableIdentifier partitionSpec? kw3=COMPACT
         | kw1=ALTER kw2=TABLE tableIdentifier partitionSpec? kw3=CONCATENATE
    +    | kw1=START kw2=TRANSACTION
    +    | kw1=COMMIT
    +    | kw1=ROLLBACK
    +    | kw1=DFS
    --- End diff --
    
    @yhuai If we do not disable them, the CLI driver will pass these commands to Hive. Below is the related code: https://github.com/gatorsmile/spark/blob/84aa14a5deda14083520e8e23f83cdb7f5bbb2bc/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala#L380-L384
    
     It will be different from what we want, I think. To make the behaviors consistent, I submitted the following PR: https://github.com/apache/spark/pull/13122
    
    Let me know if you have any concern. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org