You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2024/09/19 23:25:17 UTC
[PR] fix(CI): increase node JS heap size [superset]
rusackas opened a new pull request, #30340:
URL: https://github.com/apache/superset/pull/30340
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This is a bit of a shot in the dark, but I saw that some Jest tests were failing due to Javascript running out of heap memory (see screenshot).
My _conjecture_ is that the Native Filter tests we're struggling with are the same issue we're running into here.
So... let's throw a dart at the problem. Apparently, the default size is 1.5GB, so let's go to 4! GPT thinks this'll work for both jest, and the chrome/chromium browser we use in E2E tests, so here goes nothing! Apparently the small GH action runners have 7GB ram, so this seems reasonable-ish.
<!--- Describe the change below, including rationale and design decisions -->
<img width="1155" alt="Screenshot 2024-09-19 at 3 53 47 PM" src="https://github.com/user-attachments/assets/8fed0d3c-1c9a-4625-81b3-782d47023747">
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
If CI passes, we should be good.
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30340:
URL: https://github.com/apache/superset/pull/30340#issuecomment-2364194617
> Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does...
That's one of the less frequently flaking tests, and is probably unaffected by extra memory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30340:
URL: https://github.com/apache/superset/pull/30340#issuecomment-2362391778
> LOL, I'm literally trying to get a tattoo of that knob. Awaiting response from two artists.
After that I feel you should be granted permission to self-approve any PR making these types of changes 🎛️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30340:
URL: https://github.com/apache/superset/pull/30340#issuecomment-2364186595
Hmmm... one of the OTHER tests is failing, but (thankfully) not the usual native filters tests. Maybe I only turned it up to like 9. Let's see what a couple more GB does...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #30340:
URL: https://github.com/apache/superset/pull/30340#issuecomment-2362374745
No PR talking about dialing something up should go without a reference to Spinal Tap..

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30340:
URL: https://github.com/apache/superset/pull/30340#issuecomment-2364225196
I'm actually optimistic about the quicker part... this should use less swap, at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #30340:
URL: https://github.com/apache/superset/pull/30340#issuecomment-2362375587
> No PR talking about dialing something up should go without a reference to Spinal Tap..
>
> 
LOL, I'm literally trying to get a tattoo of that knob. Awaiting response from two artists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(CI): increase node JS heap size [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #30340:
URL: https://github.com/apache/superset/pull/30340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org