You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/11/06 12:27:33 UTC
[GitHub] [iotdb] SteveYurongSu opened a new pull request #1973: [IOTDB-985] Unclear message when password is wrong
SteveYurongSu opened a new pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973
JIRA: https://issues.apache.org/jira/projects/IOTDB/issues/IOTDB-985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #1973: [IOTDB-985] Unclear message when password is wrong
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #1973: [IOTDB-985] Unclear message when password is wrong
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973#issuecomment-723180605
> Tests failed...
> Fix CI and cherry pick the commit to rel/0.11 branch?
CI was fixed and the PR for rel/0.11 is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #1973: [IOTDB-985] Unclear message when password is wrong
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973#discussion_r518795851
##########
File path: cli/src/main/java/org/apache/iotdb/cli/Cli.java
##########
@@ -159,9 +159,7 @@ private static void receiveCommands(ConsoleReader reader) throws TException, IOE
}
} catch (SQLException e) {
println(String
- .format("%s> %s Host is %s, port is %s.", IOTDB_CLI_PREFIX, e.getMessage(), host,
- port));
+ .format("%s> %s. Host is %s, port is %s.", IOTDB_CLI_PREFIX, e.getMessage(), host, port));
Review comment:
```suggestion
.format("%s> %s Host is %s, port is %s.", IOTDB_CLI_PREFIX, e.getMessage(), host, port));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou edited a comment on pull request #1973: [IOTDB-985] Unclear message when password is wrong
Posted by GitBox <gi...@apache.org>.
HTHou edited a comment on pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973#issuecomment-723115393
Tests failed...
Fix CI and cherry pick the commit to rel/0.11 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #1973: [IOTDB-985] Unclear message when password is wrong
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973#issuecomment-723115393
Cherry pick to rel/0.11 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou edited a comment on pull request #1973: [IOTDB-985] Unclear message when password is wrong
Posted by GitBox <gi...@apache.org>.
HTHou edited a comment on pull request #1973:
URL: https://github.com/apache/iotdb/pull/1973#issuecomment-723115393
Tests failed...
Cherry pick to rel/0.11 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org