[GitHub] [incubator-pinot] snleee commented on a change in pull request #4489: [Instance Assignment] Add configs for instance assignment

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4489: [Instance Assignment] Add configs for instance assignment
URL: https://github.com/apache/incubator-pinot/pull/4489#discussion_r309898630
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
 ##########
 @@ -82,6 +85,10 @@
   @NestedConfig
   private RoutingConfig _routingConfig;
 
+  @ConfigKey(INSTANCE_ASSIGNMENT_CONFIG_MAP_KEY)
+  @UseChildKeyHandler(InstanceAssignmentConfigMapChildKeyHandler.class)
+  private Map<InstancePartitionsType, InstanceAssignmentConfig> _instanceAssignmentConfigMap;
 
 Review comment:
   Map will be the best approach? We should consider other options to make this simpler. (e.g. put `instanceAssignmentConfigMap` + override config. `TenantConfig` is also using overriding config approach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org