You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/08/19 22:19:28 UTC
Review Request 24867: Alerts: Updating an AlertDefinition With Partial
Property Maps
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24867/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-6924
https://issues.apache.org/jira/browse/AMBARI-6924
Repository: ambari
Description
-------
An existing AlertDefinition should be able to be updated with a partial set of properties. The logic for updating and creating can be extracted and combined into a single method.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bed25e752f2fd5dd036e95818be417efbec9ead4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java ab746142d90f91636152fbd74780dd201373c815
Diff: https://reviews.apache.org/r/24867/diff/
Testing
-------
Ran alert-related tests.
Thanks,
Jonathan Hurley
Re: Review Request 24867: Alerts: Updating an AlertDefinition With
Partial Property Maps
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24867/#review51103
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Aug. 19, 2014, 4:19 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24867/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 4:19 p.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-6924
> https://issues.apache.org/jira/browse/AMBARI-6924
>
>
> Repository: ambari
>
>
> Description
> -------
>
> An existing AlertDefinition should be able to be updated with a partial set of properties. The logic for updating and creating can be extracted and combined into a single method.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java bed25e752f2fd5dd036e95818be417efbec9ead4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java ab746142d90f91636152fbd74780dd201373c815
>
> Diff: https://reviews.apache.org/r/24867/diff/
>
>
> Testing
> -------
>
> Ran alert-related tests.
>
>
> Thanks,
>
> Jonathan Hurley
>
>